Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazy load sources #59

Closed
wants to merge 7 commits into from
Closed

Lazy load sources #59

wants to merge 7 commits into from

Conversation

gbjk
Copy link
Contributor

@gbjk gbjk commented Sep 7, 2014

Same as jhthorsen's original PR.
Rebased and fixed for changes since.

I'll be going through testing of this in the coming week.

Jan Henning Thorsen and others added 5 commits September 5, 2014 18:21
@gbjk
Add support for load_namespaces(lazy_load => 1, ...)
efd8969 
  All tests successful.
  Files=94, Tests=20844, 25 wallclock secs
  Result: PASS

  All database related tests was skipped when running this test suite.
@gbjk
lazy_load: sources() returns available source names
1dae24c
@gbjk
Made fa96ac0 work wit the rest of the test suite
ffd98fb 
  All tests successful.
  Files=94, Tests=20848, 51 wallclock secs
  Result: PASS
@gbjk
Fix lazy load sources for latest releases
b7c2f1f
@gbjk
Fix connect vivifying all sources anyway
8f7ebb0
@ribasushi ribasushi mentioned this pull request Sep 7, 2014
Closed
@jhthorsen
Copy link

See also #32 for old discussion.

@gbjk
Copy link
Contributor Author

gbjk commented Sep 7, 2014

Tests failing in new and exciting ways.

I'll work on fixing them, so this can be merged.

Not ignoring, either, riba's comment that this can't be merged until the substrate it's landing in is settled, unless we accept responsibility for ensuring it works both before and after significant changes in the undergrowth it's trying to live in.

@gbjk
Fix Skipping of non-loaded sources.
5ff4f94 
Checking the file simply won't work, but even if it would, this wasn't the module name.
The source_registrations gives us a better handle on "has this been vivified or not"
@gbjk
Fix Module::Loaded leaked.
ea168c0 
Also noted that it's after namespace autoclean!
@mcsnolte
Copy link

👍 for this feature 😄

@mcsnolte
Copy link

@gbjk did you have any more ideas on how to make this work? Thanks

@gbjk
Copy link
Contributor Author

gbjk commented Dec 15, 2015

I stopped sniffing at this as it felt like the substrate we'd built upon was unsettled.
I think if I recall correctly the issue was that we built this on a branch that didn't end up getting folded into a release at the time. I checked months later, and it still hadn't happened.
I think I need to touch base with @ribasushi about this. I would have done so at LPW but I was unfortunately not able to attend. I'll grab him some time soon to discuss.

For what it's worth, we've actually been running this in production for well over a year now.

@mcsnolte
Copy link

Nice! Thanks for the update @gbjk

@ribasushi
Copy link
Collaborator

Am busy getting things into shape for 0.082830. Will make sure to post an update / future plan / holdup description for my successor before I sign off.

@gbjk
Copy link
Contributor Author

gbjk commented Sep 26, 2023

StaleAF.

@gbjk gbjk closed this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Post-0.0829xx
Projects
None yet
Milestone
No milestone
4 participants
@gbjk @jhthorsen @mcsnolte @ribasushi