Add _merge_joinpref_attr test w/ {}/undef (empty) vals #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a test for the case of join attrs specified with empty ({} or
undef) vals (i.e. join => { rel => { rel2 => {} } }). These tests pass,
however, the empty {} vals currently produce uninitialized warnings.
For further reference, these warnings were bypassed for RapidApp in this
commit:
vanstyn/RapidApp@6f41f6e48
This test was added per the request of @ribasushi
dbsrgits-sync
force-pushed
the
current/for_cpan_index
branch
from
e81ec1f
to
e52712a
Compare
dbsrgits-sync
force-pushed
the
current/for_cpan_index
branch
from
4aaf6fd
to
b3f3814
Compare
dbsrgits-sync
force-pushed
the
current/for_cpan_index
branch
2 times, most recently
from
11cec86
to
2a89732
Compare
dbsrgits-sync
force-pushed
the
current/for_cpan_index
branch
from
1282683
to
4bfba4e
Compare
dbsrgits-sync
force-pushed
the
current/for_cpan_index
branch
from
0824a0c
to
ca30d84
Compare
|
Applied (and fixed) as a8e561e30. Barring failures will show up on CPAN this week as 0.082820. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test for the case of join attrs specified with empty ({} or
undef) vals (i.e. join => { rel => { rel2 => {} } }). These tests pass,
however, the empty {} vals currently produce uninitialized warnings.
For further reference, these warnings were bypassed for RapidApp in this
commit:
vanstyn/RapidApp@6f41f6e48
This test was added per the request of @ribasushi