-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bold text #80
base: current/blead
Are you sure you want to change the base?
Add bold text #80
Conversation
Wasted 30 minutes trying to join to a table name instead of relationship (even though I was franticly digging through the docs)
|
Thank you for the contribution! I am afraid that the bolding alone will not really work, as it would imply that this is an exception, not a rule. In reality there is only one single spot within the DBIx::Class API where you are going to use the actual source name - the call to ->table() itself, at metadata declaration time. Nowhere else will you be able to use the original table name, as any source is aliased either to Also would it be possible to do a general grep on the documentation and expand this to other spots? |
|
I think I could revise to include some other docs, yes. The issue is for some of us, we know and have used DBIx::Class many times, it is just sometimes months go by in between usage and as a quick refresher (at least for me), the cookbook examples are used since they are more advanced. And this can lead to missing out on some concepts that might have been coved better elsewhere in the docs. |
|
On 07/15/2015 08:34 PM, Samuel Smith wrote:
Right. I don't mind the actual fix. I am worried about the inconsistent Thanks in advance! |
|
I just read through most of the docs. At least in DBIx::Class::Manual::Joining, it is clear that table names are not used. Looking at other 'cookbook' style docs in cpan shows they are normally more of a hodgepodge of examples and documentation. In this case I think a little bolding of certain words and concepts are warranted and doesn't lead to fragmentation. Your call on a merge. |
4bc1f7b
to
606ff39
Compare
f2e955c
to
1f99022
Compare
Wasted 30 minutes trying to join to a table name instead of relationship (even though I was franticly digging through the docs)