added ambiguous column description #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @ribasushi, thanks for commenting my commit. I've added some error messages, a short description and an example how to use the function. I hope with my changes it now fits the needs of the documentation. |
|
I am traveling this and next week, sorry for the slower than usual response. This will be reviewed/merged by end of next week. Cheers! |
dbsrgits-sync
force-pushed
the
current/blead
branch
from
4bc1f7b
to
606ff39
Compare
dbsrgits-sync
force-pushed
the
current/blead
branch
from
f2e955c
to
1f99022
Compare
|
? |
|
Ah, sry. I thought that was completed and in my fork. Cleaning up my issues at the moment. IDK if that commits made it to master. |
|
Not just yet, but would not have been lost either way as I track PRs outside of github. Reopening either way. |
abraxxa
suggested changes
Jun 16, 2020
abraxxa
approved these changes
Jun 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first pull request to the Project. I hope it fit your needs.
I've added a description how to solve Problems with ambiguous columns in ResultSets.
If something don't fit your needs, just let me a note. I will refactor my changes then.