Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set minimum Perl version #10

Conversation

@paultcochrane
Copy link
Contributor

@paultcochrane paultcochrane commented Feb 15, 2018

I'm not 100% if this is the correct way to set the minimum Perl version for this dist. Sometimes Dist::Zilla power users have other ways of setting such parameters, so I'm unsure if I've got this right. Nevertheless, this PR can be considered as a discussion starter.

The initial impetus for this PR is from CPANTS, which mentions that the minimum Perl version is missing for this dist.

I've chosen Perl 5.8 as the minimum version because the prereqs of this dist don't seem to be able to build and install under 5.6.2. Under 5.8.9 everything builds fine and the dist's tests run without problems (when building and testing the source of the current dist version from CPAN (0.28)).

As with all my PRs, this is submitted in the hope that it is useful and if you need anything changed, please just let me know and I'll update the PR and resubmit as necessary.

@yanick
Copy link
Contributor

@yanick yanick commented Feb 15, 2018

5.8 sounds like a perfectly good minimal version to me. 👍

@yanick yanick added this to the v0.29 milestone Feb 15, 2018
@yanick yanick self-assigned this Feb 15, 2018
yanick added a commit that referenced this issue Feb 15, 2018
 - Set minimal Perl version to be 5.8. [GH#10, Paul Cochrane]

Fixes #10
@yanick yanick closed this Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants