New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge trailing whitespace #14

Merged
merged 2 commits into from Feb 17, 2018

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Feb 17, 2018

Trailing whitespace is seen in some projects as bad practice (e.g. the Linux kernel) and is hence explicitly forbidden; other projects see its removal as plain nit-picking. This PR is submitted in the hope that it is helpful, however if you don't see any need to remove such whitespace I'm happy if you close the PR as unmerged. As before, I've split the commits so that you can cherry pick them as required. If you want these changes to be bundled into one commit, just let me know and I'll update the PR and resubmit.

@yanick yanick added this to the v0.29 milestone Feb 17, 2018

@yanick

This comment has been minimized.

Contributor

yanick commented Feb 17, 2018

Personally, end-of-line whitespaces don't fill me with the same horror that they seem to inspire to the community at large. But hey, if you went through the trouble of removing them, I see no reason not to honor your toil. :-)

@yanick yanick merged commit b3b1055 into PerlDancer:master Feb 17, 2018

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

yanick added a commit that referenced this pull request Feb 17, 2018

merge branch 'pr/14'
 - Remove trailing whitespaces. [GH#14, Paul Cochrane]
   - Fix for Dancer > v1.3012
   - Add support for session_secure to serve https only cookies.
   - Add missing MYMETA.yml
   - Make Dancer::Session::Cookie honor the session_name setting
   - Fix for Dancer > v1.3012
   - Add support for session_secure to serve https only cookies.
   - Add missing MYMETA.yml
   - Make Dancer::Session::Cookie honor the session_name setting

Fixes #14

yanick added a commit that referenced this pull request Feb 17, 2018

merge branch 'pr/15'
 - Remove trailing whitespaces. [GH#14, Paul Cochrane]
 - Misc code cleanup. [GH#14, GH#15, Paul Cochrane]

Fixes #14, Fixes #14, Fixes #15

yanick added a commit that referenced this pull request Feb 17, 2018

merge branch 'pr/16'
 - Misc code cleanup. [GH#14, GH#15, Paul Cochrane]
 - Misc code cleanup. [GH#14, GH#15, GH#16, Paul Cochrane]

Fixes #14, Fixes #15, Fixes #14, Fixes #15, Fixes #16

yanick added a commit that referenced this pull request Feb 17, 2018

merge branch 'pr/17'
 - Misc code cleanup. [GH#14, GH#15, GH#16, Paul Cochrane]
 - Misc code cleanup. [GH#14, GH#15, GH#16, GH#17, Paul Cochrane]

Fixes #14, Fixes #15, Fixes #16, Fixes #14, Fixes #15, Fixes #16, Fixes #17

@paultcochrane paultcochrane deleted the paultcochrane:pr/purge-trailing-whitespace branch Feb 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment