Use strict and warnings pragmas consistently in tests #17
Conversation
added 2 commits
Feb 17, 2018
It was noticed that other test files use the strict and warnings pragmas, however this file didn't. This change improves the internal consistency of the test files' content.
The strict and warnings pragmas need to be a the start of a file in order that perlcritic won't complain about them being missing. These files actually already had the pragmas present, they just needed to be moved before the first line of other code. This change ensures that the test files have an internally consistent structure.
|
Merged to master, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
These commits ensure that a) strict and warnings pragams are present, and b) that they are always at the top of the test file so as to ensure a consistent structure in all test files. This change also ensures that perlcritic doesn't complain about missing strict or warnings pragmas and thus allows the code to pass the perlcritic "gentle" severity.