New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use strict and warnings pragmas consistently in tests #17

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@paultcochrane
Contributor

paultcochrane commented Feb 17, 2018

These commits ensure that a) strict and warnings pragams are present, and b) that they are always at the top of the test file so as to ensure a consistent structure in all test files. This change also ensures that perlcritic doesn't complain about missing strict or warnings pragmas and thus allows the code to pass the perlcritic "gentle" severity.

Paul Cochrane added some commits Feb 17, 2018

Paul Cochrane
Add strict and warnings pragmas
It was noticed that other test files use the strict and warnings
pragmas, however this file didn't.  This change improves the internal
consistency of the test files' content.
Paul Cochrane
Move strict/warnings pragmas to start of test files
The strict and warnings pragmas need to be a the start of a file in
order that perlcritic won't complain about them being missing.  These
files actually already had the pragmas present, they just needed to be
moved before the first line of other code.  This change ensures that the
test files have an internally consistent structure.

yanick added a commit that referenced this pull request Feb 17, 2018

merge branch 'pr/17'
 - Misc code cleanup. [GH#14, GH#15, GH#16, Paul Cochrane]
 - Misc code cleanup. [GH#14, GH#15, GH#16, GH#17, Paul Cochrane]

Fixes #14, Fixes #15, Fixes #16, Fixes #14, Fixes #15, Fixes #16, Fixes #17

@yanick yanick added this to the v0.29 milestone Feb 17, 2018

@yanick

This comment has been minimized.

Contributor

yanick commented Feb 17, 2018

Merged to master, thanks!

@yanick yanick closed this Feb 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment