Dancer::Session::Abstract doesn't use inherited session_name methods #1004

Closed
lecar-red opened this Issue Mar 23, 2014 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

lecar-red commented Mar 23, 2014

According to the docs,

session_name (optional)
Returns a string with the name of cookie used for storing the session ID.

You should probably not override this; the user can control the cookie name using the session_name setting.

But the abstract methods read_session_id and write_session_id don't use session_name via method, therefore session engine providers overridden methods don't work:

Example:

sub read_session_id {
    my $name = session_name();
...

this should be:

sub read_session_id {
   my $class = shift;
   my $name  = $self->session_name;
...

@lecar-red lecar-red added a commit to lecar-red/Dancer that referenced this issue Mar 23, 2014

@lecar-red lecar-red changed session to use class method names to fix #1004 7117f11

@lecar-red lecar-red added a commit to lecar-red/Dancer that referenced this issue Mar 23, 2014

@lecar-red lecar-red changed session to use class method names to fix #1004 5c65afd

yanick closed this in 6bf7a40 Mar 26, 2014

@yanick yanick added a commit that referenced this issue Mar 26, 2014

@yanick yanick changelog
Fixes #1004
Fixes #1005
346292f
Contributor

yanick commented Mar 26, 2014

Excellent. Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment