Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dancer::Session::Abstract doesn't use inherited session_name methods #1004

Closed
lecar-red opened this issue Mar 23, 2014 · 1 comment
Closed

Dancer::Session::Abstract doesn't use inherited session_name methods #1004

lecar-red opened this issue Mar 23, 2014 · 1 comment

Comments

@lecar-red
Copy link
Contributor

@lecar-red lecar-red commented Mar 23, 2014

According to the docs,

session_name (optional)
Returns a string with the name of cookie used for storing the session ID.

You should probably not override this; the user can control the cookie name using the session_name setting.

But the abstract methods read_session_id and write_session_id don't use session_name via method, therefore session engine providers overridden methods don't work:

Example:

sub read_session_id {
    my $name = session_name();
...

this should be:

sub read_session_id {
   my $class = shift;
   my $name  = $self->session_name;
...
lecar-red added a commit to lecar-red/Dancer that referenced this issue Mar 23, 2014
lecar-red added a commit to lecar-red/Dancer that referenced this issue Mar 23, 2014
@yanick yanick closed this in 6bf7a40 Mar 26, 2014
yanick added a commit that referenced this issue Mar 26, 2014
Fixes #1004
Fixes #1005
@yanick
Copy link
Contributor

@yanick yanick commented Mar 26, 2014

Excellent. Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.