Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Midleading plack_middlewares documentation #844

Closed
berekuk opened this Issue Oct 9, 2012 · 1 comment

Comments

Projects
None yet
1 participant
Contributor

berekuk commented Oct 9, 2012

Dancer::Cookbook implicitly suggests that middleware arguments should be enclosed in []:

    set plack_middlewares => [
        [ 'Debug' => [ 'panels' => [qw(DBITrace Memory Timer)] ] ],
    ];

But the actual code passes its arguments to add_middleware, and Plack::Builder expects a list, not arrayref.

Contributor

berekuk commented Oct 10, 2012

Looks like it's a dup of #760. Sorry.

@berekuk berekuk closed this Oct 10, 2012

@pjf pjf added a commit to pjf/Dancer that referenced this issue Nov 20, 2012

@pjf pjf Fix Bug #844/#760 - Misleading plack middleware documentation
The Plack middlware interface expects an array of arrays, where
the first element of each one is the middleware name, and the rest
are the arguments to that middleware.  The Cookbook suggests a
name and array-reference is required.

This change adjusts the data structures used appropriately (both
in code and in YAML).

Tested against Dancer 1.3095 and Plack 0.9988
8255b66

@pjf pjf added a commit to pjf/Dancer that referenced this issue Nov 20, 2012

@pjf pjf Fix Bug #844/#760 - Misleading plack middleware documentation
The Plack middlware interface expects an array of arrays, where
the first element of each one is the middleware name, and the rest
are the arguments to that middleware.  The Cookbook suggests a
name and array-reference is required.

This change adjusts the data structures used appropriately (both
in code and in YAML).

Tested against Dancer 1.3095 and Plack 0.9988
1700f6e

@xsawyerx xsawyerx added a commit that referenced this issue Nov 25, 2012

@pjf @xsawyerx pjf + xsawyerx Fix Bug #844/#760 - Misleading plack middleware documentation
The Plack middlware interface expects an array of arrays, where
the first element of each one is the middleware name, and the rest
are the arguments to that middleware.  The Cookbook suggests a
name and array-reference is required.

This change adjusts the data structures used appropriately (both
in code and in YAML).

Tested against Dancer 1.3095 and Plack 0.9988
e8f8288

@mokko mokko added a commit to mokko/Dancer that referenced this issue Nov 25, 2012

@pjf @mokko pjf + mokko Fix Bug #844/#760 - Misleading plack middleware documentation
The Plack middlware interface expects an array of arrays, where
the first element of each one is the middleware name, and the rest
are the arguments to that middleware.  The Cookbook suggests a
name and array-reference is required.

This change adjusts the data structures used appropriately (both
in code and in YAML).

Tested against Dancer 1.3095 and Plack 0.9988
881506f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment