Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Dancer::Serializer ignoring content for DELETE method #965

Closed
a-adam opened this Issue Sep 25, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

a-adam commented Sep 25, 2013

Dancer::Serializer skips the deserialization of content for DELETE:

sub process_request {
[...]
return $request
unless $request->is_put || $request->is_post || $request->is_patch;

IMO, this is not the case for standard url-encoded content, i.e. it is a divergence within Dancer.
content in DELETE is not explicitely forbidden by the RFC; and it makes sense for `writing' methods such as DELETE.

Contributor

yanick commented Sep 26, 2013

I agree. The latest draft of the RFC explicit say that the behavior for content is not forbidden, merely unspecified: http://tools.ietf.org/html/draft-ietf-httpbis-p2-semantics-24#section-4.3.5

I'll put in a patch for the next release.

@ghost ghost assigned yanick Sep 26, 2013

Contributor

a-adam commented Sep 26, 2013

thanks -- also generally for maintaining that nice framework!
Note: Dancer2 has the same issue, IMO.

@yanick yanick closed this in 08aee4e Sep 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment