Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Update plugins from old plugin system to new plugin system #1078
This is a ticket to track all the plugins that do not work on the new plugin system and also which ones have been converted to pure plugin2.
Release OK or fixed/PR in repo: 61/68 ~ 90%
|Emailesque||no||CPAN||GitHub : visual verification (no tests)|
|LogReport||no||CPAN||no public repo|
|ProbabilityRoute||no||CPAN||Github : manual testing using demo|
👍 Release broken but fixed in GH upstream:
👎 Release broken but PR submitted:
|Auth::YARBAC||CPAN||Github : PR|
❓ Unknown (no tests)
|GoogleAnalytics||CPAN||Github repo disappeared|
Due to this in the test:
PR submitted ironcamel/Dancer2-Plugin-DBIC#13
Two problems here. One was solved by using
That change is in the master branch of my fork: https://github.com/SysPete/Dancer2-Plugin-JWT
Still leaves the
Diff is pretty simple:
Using the new
Using the 'sub foo :PluginKeyword` alternative does not trigger the warning.
On 12/30/2015 01:49 PM, Henk van Oers wrote:
It doesn't have any special patches for D2P2, so it is uncertain. I'll check that.
Perl and Dancer Development
Visit our Perl::Dancer conference 2015.
It throws a lot of warnings:
Throwing warnings is on purpose. It's like that so you would have to upgrade. The warnings will only be thrown if someone uses an older version of the plugin (which uses the older D2::P plugin interface) while the new D2::P interface is available.
This means that you release this version now - no warnings yet. We release a new version of Dancer2 with the new D2::P and then you have warnings until you upload a new version that uses the new interface.
That's the deprecation cycle.
Also, I pushed a fix for the last uninitialized error.
I will make time tonight to fix this, and also look at the other D2::P::HTTP modules that I wrote.
Peter, with your changes, I run into trouble...
Failed test 'use Dancer2::Plugin::HTTP::Auth::Extensible;'
at t/00-load.t line 6.
Tried to use 'Dancer2::Plugin::HTTP::Auth::Extensible'.
Error: syntax error at /Volumes/Repositories/THEMA-MEDIA/Dancer2-Plugin-HTTP-Auth-Extensible/blib/lib/Dancer2/Plugin/HTTP/Auth/Extensible.pm line 20, near "has default_realm”
Error: Can't locate Dancer2/Core/Types.pm in @inc (you may need to install the Dancer2::Core::Types module) (@inc contains: /Volumes/Repositories/THEMA-MEDIA/Dancer2-Plugin-HTTP-Auth-Extensible/lib /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/site_perl/5.18.4/darwin-2level /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/site_perl/5.18.4 /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/5.18.4/darwin-2level /Users/tvanhoesel/perl5/perlbrew/perls/perl-5.18.4/lib/5.18.4) at /Volumes/Repositories/THEMA-MEDIA/Dancer2-Plugin-HTTP-Auth-Extensible/lib/Dancer2/Plugin/HTTP/Auth/Extensible.pm line 7.
$Dancer2::Core::Types::VERSION 0.166001 (just did a clean install for Dancer2::Plugin , which installs everything)
Some advice is really welcome
@vanHoesel apologies - I did not make it clear in PRs...
The latest updates to your plugin will work ONLY with plugin2 which will be released as part of Dancer2 v0.200000 this weekend (assuming all goes well). For a small number of plugins (those that themselves use other plugins) it is not possible to be compatible with both current Dancer2 and also the next release.
You can test against the latest DEV release: cpanm --dev Dancer2
For all who it may concern…
doing a (clean) install for —dev Dancer2:
! Installing the dependencies failed: Module 'Type::Tiny' is not installed
after installing that:
[App::Basic:5341] error @2016-05-27 12:39:26> Route exception: Can't locate object method "_parse_query" via package "Dancer2::Core::Request" at /Users/tvanhoesel/.cpanm/work/1464349136.4981/Dancer2-0.166001_03/blib/lib/Dancer2/Core/Request.pm line 349. in /Users/tvanhoesel/.cpanm/work/1464349136.4981/Dancer2-0.166001_03/blib/lib/Dancer2/Core/App.pm l. 837
Failed test 'Query parameters'
at t/dsl/parameters.t line 51.
Looks like you failed 1 test of 7.
I will force install it, it was the ONLY failing test:
Failed 1/149 test programs. 1/1476 subtests failed.
Cheers … will continue to work on my HTTP Modules
This was referenced
Jul 28, 2016
What's the recommended procedure for converting a plugin that may import an unspecified number of keywords into the app? I use Dancer2::Plugin::LogContextual, which imports a set of keywords via
A bit o' sample code: