Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should lack of Test::Perl::Critic prevent install? #1273

Closed
nanis opened this issue Oct 12, 2016 · 3 comments

Comments

Projects
None yet
2 participants
@nanis
Copy link
Contributor

commented Oct 12, 2016

I am asking this question, because I just ran into this on my test rig. cpanm Dancer2 failed because Test::Perl::Critic depends on MCE and it looks like some MCE tests are crashing with the particular build of perl (never had problems before, and I haven't diagnosed it yet).

But, this made me think about why there is a test_requires 'Test::Perl::Critic'; in cpanfile and

"TEST_REQUIRES" => {
    "Test::Perl::Critic" => 0
  },

in Makefile.PL.

It seems to me that critic tests are for authors only, and the failure to run or pass those tests should not prevent an automated test/install of Dancer2? Of course, if I just unpack the distribution and do nmake test, I get the warning:

# *** WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING ***
#
# The following REQUIRED prerequisites were not satisfied:
#
# Test::Perl::Critic is not installed (any version required)

but all tests pass.

@xsawyerx

This comment has been minimized.

Copy link
Member

commented Oct 12, 2016

Oh dear! No. This shouldn't happen!

@xsawyerx

This comment has been minimized.

Copy link
Member

commented Oct 16, 2016

Fixed by @episodeiv and merged!

Thanks!

@xsawyerx xsawyerx closed this Oct 16, 2016

@nanis

This comment has been minimized.

Copy link
Contributor Author

commented Oct 17, 2016

Thank you.

cromedome added a commit that referenced this issue Oct 17, 2016

v0.204001
    [ BUG FIXES ]
    * Restore 5.8 support (fix test which required captures).
      (Russell @veryrusty Jenkins)
    * PR #1271: fix wrong regex check against $_ (Mickey Nasriachi)

    [ ENHANCEMENTS ]
    * GH #1262: Add 'encode_json' and 'decode_json' DSL, which are
      recommended instead of 'to_json' and 'from_json'.
      (Dennis @episodeiv lichtenthäler)

    [ DOCUMENTATION ]
    * Fix some typos.(Dennis @episodeiv lichtenthäler)
    * GH #1031: Remove D2::Core::Context remnants from docs.
      (Sawyer X)

    [ PACKAGING ]
    * GH #1273: Do not require Test::Perl::Critic to install.
      (Dennis lichtenthäler)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.