Should lack of Test::Perl::Critic prevent install? #1273

Closed
nanis opened this Issue Oct 12, 2016 · 3 comments

Projects

None yet

2 participants

@nanis
Contributor
nanis commented Oct 12, 2016

I am asking this question, because I just ran into this on my test rig. cpanm Dancer2 failed because Test::Perl::Critic depends on MCE and it looks like some MCE tests are crashing with the particular build of perl (never had problems before, and I haven't diagnosed it yet).

But, this made me think about why there is a test_requires 'Test::Perl::Critic'; in cpanfile and

"TEST_REQUIRES" => {
    "Test::Perl::Critic" => 0
  },

in Makefile.PL.

It seems to me that critic tests are for authors only, and the failure to run or pass those tests should not prevent an automated test/install of Dancer2? Of course, if I just unpack the distribution and do nmake test, I get the warning:

# *** WARNING WARNING WARNING WARNING WARNING WARNING WARNING WARNING ***
#
# The following REQUIRED prerequisites were not satisfied:
#
# Test::Perl::Critic is not installed (any version required)

but all tests pass.

@xsawyerx
Member

Oh dear! No. This shouldn't happen!

@episodeiv episodeiv pushed a commit to episodeiv/Dancer2 that referenced this issue Oct 16, 2016
Dennis Lichtenthäler As per issue #1273, Test::Perl::Critic should only be an author test 0b69dfd
@xsawyerx xsawyerx added a commit that referenced this issue Oct 16, 2016
@xsawyerx Dennis Lichtenthäler + xsawyerx As per issue #1273, Test::Perl::Critic should only be an author test 13cd971
@xsawyerx
Member

Fixed by @episodeiv and merged!

Thanks!

@xsawyerx xsawyerx closed this Oct 16, 2016
@nanis
Contributor
nanis commented Oct 17, 2016

Thank you.

@cromedome cromedome added a commit that referenced this issue Oct 17, 2016
@cromedome cromedome v0.204001
    [ BUG FIXES ]
    * Restore 5.8 support (fix test which required captures).
      (Russell @veryrusty Jenkins)
    * PR #1271: fix wrong regex check against $_ (Mickey Nasriachi)

    [ ENHANCEMENTS ]
    * GH #1262: Add 'encode_json' and 'decode_json' DSL, which are
      recommended instead of 'to_json' and 'from_json'.
      (Dennis @episodeiv lichtenthäler)

    [ DOCUMENTATION ]
    * Fix some typos.(Dennis @episodeiv lichtenthäler)
    * GH #1031: Remove D2::Core::Context remnants from docs.
      (Sawyer X)

    [ PACKAGING ]
    * GH #1273: Do not require Test::Perl::Critic to install.
      (Dennis lichtenthäler)
74a490f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment