Skip to content

Rewrite of the CLI #371

Closed
xsawyerx opened this Issue Aug 8, 2013 · 7 comments

4 participants

@xsawyerx
PerlDancer member
xsawyerx commented Aug 8, 2013

I'd like to rewrite the entire dancer command line app. I'm thinking of something akin to App::Cmd (whether it's actually used or not in the end) with multiple possible commands, being able to manage a Dancer app instead of just scaffolding one.

I'd like to collect thoughts on what this might support. Obviously creating a new application, but what else? Stuff like sanity checks, adding modules, setting up various default configurations (dzil?), set up packaging (support via FatPacker or Carton) - these are some ideas.

What do you think?

@odyniec
PerlDancer member
odyniec commented Aug 15, 2013

It would be a good idea to make it easily extensible with plugins, allowing them to add new commands. I was thinking of this back when I was working on Dancer::Plugin::Auth::Basic and Dancer::Plugin::Auth::Htpasswd -- I thought it would be useful if the command line app allowed the user to generate an encrypted passphrase or create a .htpasswd file, without the use of other tools.

@yanick
@yanick
yanick commented Aug 16, 2013

Ah, not a blog entry, an advent calendar entry: http://advent.perldancer.org/2012/10 :-)

@xsawyerx
PerlDancer member

@odyniec the way I want to write it (using App::Cmd) would allow for additional commands to be written as plugins very easily. I like the ideas you added.

@yanick so basically we're talking about the ability to create apps and to edit them.

@xsawyerx
PerlDancer member
xsawyerx commented Sep 2, 2013

@ikruglov has started work on it. It's essentially done but needs thorough review.
It's available in the master branch here: https://github.com/ikruglov/Dancer2/commits/master.

@ikruglov, please add any comments you may have here as well.

@ikruglov
ikruglov commented Sep 2, 2013

Hi everyone,

I should say that script/dancer2-cli rely on File::ShareDir::dist_dir to return folder where the installer copied all templates files to (share/skel). But i didn't actually test that part. So, if it fails, copy 'share/skel' into whetever path File::ShareDir::dist_dir returns in your case.

@ikruglov ikruglov added a commit to ikruglov/Dancer2 that referenced this issue Nov 15, 2013
@ikruglov ikruglov Rewrite dancer2 cli #371 708abc3
@ikruglov ikruglov added a commit to ikruglov/Dancer2 that referenced this issue Nov 18, 2013
@ikruglov ikruglov rename dancer2-cli, add DANCER2_SHARE_DIR #371 3713767
@ikruglov ikruglov added a commit to ikruglov/Dancer2 that referenced this issue Nov 21, 2013
@ikruglov ikruglov include encoding fix from samitbadle #371 49e2a2a
@ikruglov ikruglov added a commit to ikruglov/Dancer2 that referenced this issue Nov 26, 2013
@ikruglov ikruglov fix issue with broken templates in share/skel #371 0a61e74
@xsawyerx xsawyerx added a commit that referenced this issue Dec 7, 2013
@ikruglov ikruglov Rewrite dancer2 cli #371 06c8a9b
@xsawyerx
PerlDancer member
xsawyerx commented Dec 7, 2013

This issue was fixed by PR #506 by @ikruglov.

Thank you! :)

@xsawyerx xsawyerx closed this Dec 7, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.