dancer2 -a creates both MANIFEST and MANIFEST.SKIP #497

Closed
szabgab opened this Issue Oct 24, 2013 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

szabgab commented Oct 24, 2013

IMHO it should only generate MANIFEST.SKIP as the other file is generated from the first one.

Owner

xsawyerx commented Dec 6, 2013

Related issue: #506.

Owner

xsawyerx commented May 20, 2014

Warnings when using it without MANIFEST file:

Could not add META.yml to MANIFEST:
Could not add META.json to MANIFEST:
Owner

xsawyerx commented Sep 12, 2014

So, reading from ExtUtils::Manifest, here's an interesting bit:

If no MANIFEST.SKIP file is found, a default set of skips will be used,
similar to the example above. If you want nothing skipped, simply make an empty
MANIFEST.SKIP file.

That means there's a difference between having no MANIFEST.SKIP, having an empty MANIFEST.SKIP, and one with content. This also implies having both a MANIFEST and a MANIFEST.SKIP are not mutually exclusive.

Thinking about it further, I'm not sure having a MANIFEST.SKIP is better than MANIFEST.

Since no one is apparently interested in this, I see no need to work on this. @szabgab, if you are still interested in this, and have time to spend on it, please reopen the issue.

Thank you.

@xsawyerx xsawyerx closed this Sep 12, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment