New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups to the request class #1045

wants to merge 2 commits into
base: master


None yet
2 participants

veryrusty commented Oct 23, 2015

Two small cleanups:

  • remove an unused var
  • no need to explicitly call $self->data within new() as the body_parameters method has already done it (one line before).

veryrusty added some commits Oct 23, 2015

Remove unused var form body_parameters method
`$env` was not used anywhere in body_parameters method.
No need to call $self->data within new()
After the HMV changes, the body_parameters method needs to check
if the body can be deserialized. This happened in the line before
we were calling $self->data. No need to do it twice.

This comment has been minimized.


xsawyerx commented Nov 4, 2015



This comment has been minimized.


veryrusty commented Nov 7, 2015

Merged as 09807c2 (fixed typo in commit message) 👯

@veryrusty veryrusty closed this Nov 7, 2015

@veryrusty veryrusty deleted the cleanup/request branch Nov 7, 2015

xsawyerx added a commit that referenced this pull request Dec 16, 2015

    * Update core team members and contributors list. (Russell Jenkins)
    * GH #1066: Fix typo in Cookbook. (gertvanoss)
    * Correct typo. It's "query_parameters", not "request_parameters".
      Thanks to mst for letting me know and making sure I fix it!
      (Sawyer X)

    [ BUG FIXES ]
    * GH #1040: Forward with a post body no longer tries to re-read body
      filehandle. (Bas Bloemsaat)
    * GH #1042: Add Diggest::SHA as explicit prequisite for installs on
      perl < v5.9.3. (Russell Jenkins)
    * GH #1071, #1070: HTML escape the message in the default error page.
      (Peter Mottram)
    * GH #1062, #1063: Command line interface didn't support
      "-s SKELETON_DIRECTORY" in any order.
      (Nuno Carvalho)
    * GH #1052, #1053: Always call before_serializer hook when serializer
      is set.
      (Mickey Nasriachi)
    * GH #1034: Correctly use different session cookie name for Dancer2.
      (Jason A. Crome)
    * GH #1060: Remove trailing slashes when providing skeleton
      (Gabor Szabo)

    * Use Plack 1.0035 to make sure you only have HTTP::Headers::Fast
      in the Plack::Request object internally.
    * GH #951 #1037: Dancer2::Template::TemplateToolkit no longer sets TT2
      INCLUDE_PATH directive, allowing `views` setting to be non-absolute
      paths. (Russell Jenkins)
    * GH #1032 #1043: Add .dancer file to new app scaffolding.
      (Jason A. Crome)
    * GH #1045: Small cleanups to Request class. (Russell Jenkins)
    * GH #1033: strict && warnings in Dancer2::CLI. (Mohammad S Anwar)
    * GH #1052, #1053: Allow before_serializer hook to change the content
      using @_.
      (Mickey Nasriachi)
    * GH #1060: Ignore .git directory when using an external skeleton
      (Gabor Szabo)
    * GH #1060: Support more asset file extensions. (Gabor Szabo)
    * GH #1072: Add request->is_options(). (Theo van Hoesel)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment