Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix wrong regex check against $_ #1271

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@mickeyn
Copy link
Contributor

commented Oct 11, 2016

pretty sure the original line shouldn't have checked against $_ and should have been:
... unless $plugin =~ /^Dancer2::Plugin::/;

while at it, we could have just add the check into a negative look-ahead on the substitution regex.

@veryrusty

This comment has been minimized.

Copy link
Member

commented Oct 11, 2016

👍

2 similar comments
@SysPete

This comment has been minimized.

Copy link
Member

commented Oct 11, 2016

👍

@xsawyerx

This comment has been minimized.

Copy link
Member

commented Oct 11, 2016

👍

@xsawyerx

This comment has been minimized.

Copy link
Member

commented Oct 11, 2016

Merge away.

@cromedome cromedome closed this Oct 17, 2016

@cromedome cromedome deleted the mickey/app_fixes branch Oct 17, 2016

cromedome added a commit that referenced this pull request Oct 17, 2016

v0.204001
    [ BUG FIXES ]
    * Restore 5.8 support (fix test which required captures).
      (Russell @veryrusty Jenkins)
    * PR #1271: fix wrong regex check against $_ (Mickey Nasriachi)

    [ ENHANCEMENTS ]
    * GH #1262: Add 'encode_json' and 'decode_json' DSL, which are
      recommended instead of 'to_json' and 'from_json'.
      (Dennis @episodeiv lichtenthäler)

    [ DOCUMENTATION ]
    * Fix some typos.(Dennis @episodeiv lichtenthäler)
    * GH #1031: Remove D2::Core::Context remnants from docs.
      (Sawyer X)

    [ PACKAGING ]
    * GH #1273: Do not require Test::Perl::Critic to install.
      (Dennis lichtenthäler)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.