Fixed session (github issue #492) #493

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

upasana-me commented Oct 11, 2013

No description provided.

Owner

veryrusty commented Oct 11, 2013

Since this occurs within has_session, if a session engine is configured, calling $self->session will always return a session object, as either a session already existed, or the builder will create one.

Whereas $self->{session} won't trigger the builder. I don't like the direct access to the underlying structure of the Moo object if it can be avoided; a predicate on the context session attribute may help.

Contributor

upasana-me commented Oct 11, 2013

Yea, I understood that later. Thank you!

Contributor

upasana-me commented Oct 11, 2013

@veryrusty Can we use reader for session? Because reader won't call builder, it'll only give the value of session, if set. Thanks.

upasana-me closed this Oct 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment