New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for inability to run Build.PL #3

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@spacebat
Contributor

spacebat commented Feb 3, 2015

I'm participating in the 2015 CPAN PR Challenge and was assigned this dist for February.

Turns out I couldn't install the module by hand, because Build.PL failed due to my lack of several build dependencies. I have modified My::Builder so that the modules I was missing are not loaded until Build.PL run time, which allows the M::B system to complete the process of creating the Build script. This allowed me to install the module and run the tests, which passed.

I've also deleted a few bits of stray whitespace, added a .gitignore and a .dir-locals.el which helps ensure emacs/cperl users use your indentation preferences.

I hope this PR is useful. Let me know if there's anything in particular that needs some attention.

spacebat added some commits Feb 2, 2015

require some modules in My::Builder at runtime
I didn't have File::Copy::Recursive and Archive::Extract
installed. Though they were listed as build deps in Build.PL, this was
being pre-empted by My::Builder using them at compile time. Now I can
run Build.PL which then installs the deps.
@plicease

This comment has been minimized.

Member

plicease commented Feb 3, 2015

Archive::Extract and File::Copy::Recursive are in the configure_requires, which means that they will be downloaded and installed by the cpan client before running perl Build.PL.

@spacebat

This comment has been minimized.

Contributor

spacebat commented Feb 4, 2015

Hi, you're quite right, sorry for the spam. cpanm --installdeps . is what I should have done. If you like I'll submit a new PR with the My::Builder modifications removed.

I'd like to help out any way I can, just let me know.

@spacebat spacebat closed this Feb 4, 2015

@plicease

This comment has been minimized.

Member

plicease commented Feb 4, 2015

This isn't spam :) Also I am not the maintainer of this distro, although I do have a commit bit, so I was more commenting on that one aspect. I think the other stuff is good, although I can't comment on the .el stuff I am not an emacs user.

One thing that would be useful for this module is to check and see if newer binaries of CMake are available for any platform(s) that you have access to. I did this a while ago for Linux and MSWin32:

e6c7226

There may be newer versions available for Linux and Windows now, and I am pretty sure there are newer versions for other platforms that were not a priority for me back then (OS X, freebsd, netbsd, solaris?) Please do not update any platforms that you cannot actually verify though.

@plicease

This comment has been minimized.

Member

plicease commented Feb 4, 2015

Another area that could help out is I notice there are a bunch of failures on Linux listed on cpantesters:

http://matrix.cpantesters.org/?dist=Alien-CMake+0.05

I just tried to reproduce this but installing worked for me. If you can reproduce the problem and fix it that would be terrific. I always hate to see so much red in the cpantesters matrix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment