Useless dependencies in META.yml #234

Closed
ppisar opened this Issue Jun 7, 2012 · 5 comments

Comments

Projects
None yet
2 participants
@ppisar

ppisar commented Jun 7, 2012

The Build.PL adds following modules to build_requires:

Archive::Tar
Archive::Zip

however they're nowhere used by the code. I think, they can be removed.

@jtpalmer

This comment has been minimized.

Show comment Hide comment
@jtpalmer

jtpalmer Jun 7, 2012

Member

Is this in reference to SDL or Alien::SDL?

Member

jtpalmer commented Jun 7, 2012

Is this in reference to SDL or Alien::SDL?

@ppisar

This comment has been minimized.

Show comment Hide comment
@ppisar

ppisar Jun 12, 2012

On Thu, Jun 07, 2012 at 02:17:49PM -0700, Jeffrey T. Palmer wrote:

Is this in reference to SDL or Alien::SDL?

Alien::SDL.

-- Petr

ppisar commented Jun 12, 2012

On Thu, Jun 07, 2012 at 02:17:49PM -0700, Jeffrey T. Palmer wrote:

Is this in reference to SDL or Alien::SDL?

Alien::SDL.

-- Petr

@jtpalmer

This comment has been minimized.

Show comment Hide comment
@jtpalmer

jtpalmer Jun 12, 2012

Member

They may not be used directly, but they are used by Archive::Extract:

https://github.com/PerlGameDev/Alien-SDL/blob/master/inc/My/Builder.pm

Member

jtpalmer commented Jun 12, 2012

They may not be used directly, but they are used by Archive::Extract:

https://github.com/PerlGameDev/Alien-SDL/blob/master/inc/My/Builder.pm

@ppisar

This comment has been minimized.

Show comment Hide comment
@ppisar

ppisar Jun 12, 2012

On Tue, Jun 12, 2012 at 04:52:41AM -0700, Jeffrey T. Palmer wrote:

They may not be used directly, but they are used by Archive::Extract:

https://github.com/PerlGameDev/Alien-SDL/blob/master/inc/My/Builder.pm

I see. Archive::Extract does not hard-require those two modules, but they are
needed to extract the SDL archive. Then it's reasonable to keep them in
build_requires.

I'm sorry for bothering you. You can close this issue as invalid.

-- Petr

ppisar commented Jun 12, 2012

On Tue, Jun 12, 2012 at 04:52:41AM -0700, Jeffrey T. Palmer wrote:

They may not be used directly, but they are used by Archive::Extract:

https://github.com/PerlGameDev/Alien-SDL/blob/master/inc/My/Builder.pm

I see. Archive::Extract does not hard-require those two modules, but they are
needed to extract the SDL archive. Then it's reasonable to keep them in
build_requires.

I'm sorry for bothering you. You can close this issue as invalid.

-- Petr

@jtpalmer

This comment has been minimized.

Show comment Hide comment
@jtpalmer

jtpalmer Jun 13, 2012

Member

No problem, always good to know people are looking at the code.

Member

jtpalmer commented Jun 13, 2012

No problem, always good to know people are looking at the code.

@jtpalmer jtpalmer closed this Jun 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment