Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

tests: remove old (and wrong) Hurd workaround #263

Closed
wants to merge 97 commits into from

10 participants

@pinotree

Other than being no more applicable with recent Hurd versions (e.g. 0.5), it was working around a bug in TestTool::init, not properly handling failures in SDL::init.

Basically it reverts commit 4931c49.

It "depends" on the pull request #262.

@kthakore

We load this stuff for other reasons.

@kthakore

Why not just get once? at line 148?

@kthakore

Erm .... change this variable name. Confusing. $icon_title.

@kthakore

why undef here? Just seems weird.

@kthakore

same problem with undef. Also I think SDLx::Controller might needs delay(), later on.

Blaizer and others added some commits
@Blaizer Blaizer fixes addressing stuff kthakore pointed out 34f1f9b
@Blaizer Blaizer merging clean 1eec190
@Blaizer Blaizer merge properly 1ad9fa5
@Blaizer Blaizer merge? 37f622a
@Blaizer Blaizer Merge branch 'Blaizer' of github.com:PerlGameDev/SDL into Blaizer 7379b0a
@Blaizer Blaizer went back to branch experimental's Controller, and added a couple sma…
…ll features as a bonus
dae4d59
@Blaizer Blaizer Merge branch 'master' of github.com:PerlGameDev/SDL into Blaizer 42390a3
@Blaizer Blaizer Merge branch 'experimental' of github.com:PerlGameDev/SDL into Blaizer 25474d0
@Blaizer Blaizer Made eoq work correctly inside pause 063a2c7
@Blaizer Blaizer Merge branch 'master' of github.com:PerlGameDev/SDL into Blaizer 6f19178
@Blaizer Blaizer Merge branch 'master' of github.com:PerlGameDev/SDL into Blaizer 2c28f32
@Blaizer Blaizer Merge branch 'master' of github.com:PerlGameDev/SDL into Blaizer 9d4903c
@Blaizer Blaizer Some changes I've been meaning to make and a little polish fd42dc9
@Blaizer Blaizer Merge branch 'master' of github.com:PerlGameDev/SDL into Blaizer 391abdf
@Blaizer Blaizer merge experimental and master 4f05641
@Blaizer Blaizer did a check with was_init instead of having to supply no_init 37694fb
@Blaizer Blaizer and now it actually works e5236f3
@Blaizer Blaizer cleaned up SDLx::App. Cleaned up SDLx::Controller and added time and …
…sleep and made eoq handler modifiable. Added a bunch of tests to controller, still not quite everything is covered. Didn't add anything to app tests, just cleaned them up a little. PODs to come next.
73348e9
@Blaizer Blaizer Completed and reworded and made the controller POD all nice and good. 91af091
@Blaizer Blaizer Forgot time and sleep in the controller pod, forgot shortcuts for par…
…am methods and fixed a bit of explanation about param methods.
d5f421c
@Blaizer Blaizer Merge branch 'master' of github.com:PerlGameDev/SDL into Blaizer c7fa7b8
@Blaizer Blaizer SDLx:App -- changed shortcuts around a lot and cleaned up everything …
…existing
e5661fb
@Blaizer Blaizer a little bit more fixing stuff daedcbc
@Blaizer Blaizer lots more fixes and tried to break less compat db40d61
@Blaizer Blaizer SDLx::App tests can_ok updated ab13f8c
@Blaizer Blaizer SDLx::App docs synopsis bf02d32
@Blaizer Blaizer SDLx::App docs description f864f81
@Blaizer Blaizer SDLx::App docs full new() example and reordered flags fd6b826
@Blaizer Blaizer SDLx::App docs full new() reordered example a2250af
@Blaizer Blaizer SDLx::App docs new() parameter explanations e013575
@Blaizer Blaizer SDLx::App set_video_mode method 77c07e9
@ioanrogers ioanrogers Make SDLx::Music match the docs: data returns hashref with no args, a…
…nd play can be called with $name
6a3b4e6
@Blaizer Blaizer SDLx::App docs for init 58a81bc
@Blaizer Blaizer SDLx::App screen_size 38e0efb
@FROGGS FROGGS Merge pull request #213 from ioanrogers/patch-1
Make SDLx::Music match the docs
6dd1a29
@Blaizer Blaizer SDLx::App docs for set_video_mode, resize, fullscreen, iconify 0a241a9
@Blaizer Blaizer fix for previous commit 57dd766
@Blaizer Blaizer SDLx::App title, icon and error and their docs. Made everything a met…
…hod again.
81fc1d7
@Blaizer Blaizer SDLx::App warp_cursor, show_cursor, grab_input and their docs 350ffca
@Blaizer Blaizer SDLx::App sync, gl_attribute and their docs 7ed6d15
@Blaizer Blaizer Docs for undocumented SDL::Surface method: flags 92bc088
@Blaizer Blaizer this should have been with the sync/gl_attribute commit fb1332f
@Blaizer Blaizer Merge branch 'master' of github.com:PerlGameDev/SDL into Blaizer 08dae96
@Blaizer Blaizer merge setting original screen res d9ae85b
@Blaizer Blaizer screen_size now returns depth as well f31d22f
@Blaizer Blaizer SDLx::App icon done and documented but transparency doesn't work.
SDLx::App is just about done now, except for some polish. Needs tests, too...
740e7f8
@Blaizer Blaizer SDLx::Controller stop_handler and its docs.
Just about finished SDLx::Controller now, too. Needs polish, tests, and... someone to tell me the docs make sense?
b84b9b3
@FROGGS FROGGS using ogg files d42771b
@FROGGS FROGGS added ogg test files 81f8d14
@FROGGS FROGGS little change for setting context, still not perfect d8db867
@FROGGS FROGGS fixed bugtracker link eec13c8
@FROGGS FROGGS added constants for SDL_DEFAULT_REPEAT_DELAY and SDL_DEFAULT_REPEAT_I…
…NTERVAL
20175d1
@Blaizer Blaizer Merging SDLx::App with a few fixes to its docs a675d57
@Blaizer Blaizer SDLx::Controller stop_handler and changed pause to work better. Fixed…
… tests. Rewrote docs. Fixed examples to comply
23347c9
@Blaizer Blaizer SDLx::Controller Gotta rewrite a bit of test code 5674d9b
@Blaizer Blaizer Using branch experimentals version of this file. Mine was broken c868dd7
@Blaizer Blaizer Fixes to App, Controller and their docs. Wrote entry for Deprecated c51f300
@Blaizer Blaizer Added ticks back in to app. It's now deprecated. 702e52d
@Blaizer Blaizer SDLx::Controller tests for pause, event_handlers and stop_handler
Also some fixes to the docs and a bunch of fixes and cleanup to the pm
d7c4271
@Blaizer Blaizer Proofread Controller docs and spellchecked app docs 9ec3940
@Blaizer Blaizer Added code for max_t and couldn't resist a bit of cleanup f96c1f8
@Blaizer

Here's the one line max_t does its work.

@kthakore
Owner

can you link the email or bug report to this?

Owner
Owner

Just why did you turn on MMX ?

Collaborator

This commit is related to: #221

@Blaizer
Collaborator

Huh...? Why?

Owner

2.538 should have been the same as 2.537_02. We don't want any non-dev releases with changes that haven't been tested with a dev release.

There were both XS and Perl versions of SDLx::Surface::draw_rect and SDLx::Surface::blit, so it looks like there was a problem with a merge.

Check out the test reports:

http://static.cpantesters.org/distro/S/SDL.html#2.538

There was also a thread on the mailing list about this if you missed it:

http://www.nntp.perl.org/group/perl.sdl.devel/2012/05/msg1902.html

I've tried re-merging the changes, but haven't had much success. Feel free giving it a try and we can put out another dev release.

bricas and others added some commits
@bricas bricas New version of GPL text (Closes #245) 4134a98
@KohaAloha KohaAloha added travis buildbot 07985c1
@FROGGS FROGGS newer SDL_gfx do not return zero-ish ticks, adjusting tests dfd08ac
@FROGGS FROGGS release 2.542 0ce7f70
@FROGGS FROGGS fix segfault when cleaning up MixChunks on windows
We built the libSDL binaries several years ago, and so it was built
against an older runtime library (msvcrt.dll).
Now we build SDL itself against msvcr110.dll for example, and therefore
allocate on another heap than the free() is taking place, which happens
in libSDL_mixer itself.
See: http://stackoverflow.com/questions/23257226/sdl-mixer-mix-freechunk-crashing-on-sample-created-in-memory
2071a33
@FROGGS FROGGS dev release 2.543_1 da5bfc0
@FROGGS FROGGS updated Alien::SDL's version to get an OpenBSD/pthread fix, dev relea…
…se 2.543_2
22e565c
@FROGGS FROGGS fix required version of dependency Alien::SDL b3408a9
@FROGGS FROGGS another attempt to correctly update dependency version of Alien::SDL f301c28
@FROGGS FROGGS release 2.544 ba434d5
@pinotree pinotree tests: remove old (and wrong) Hurd workaround
Other than being no more applicable with recent Hurd versions
(e.g. 0.5), it was working around a bug in TestTool::init, not properly
handling failures in SDL::init.

Basically it reverts commit 4931c49d1dfdc11aaf86d85db734104a37bef538.
1e4dbfa
@pinotree

Apparently this got busted somehow, will open a new one.

@pinotree pinotree closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jan 13, 2011
  1. @Blaizer

    Validate PP test.

    Blaizer authored
  2. @Blaizer

    Surface PP test.

    Blaizer authored
Commits on Mar 1, 2011
  1. @Blaizer
Commits on Aug 24, 2011
  1. @Blaizer
  2. @Blaizer
Commits on Aug 25, 2011
  1. @Blaizer

    merging clean

    Blaizer authored
  2. @Blaizer

    merge properly

    Blaizer authored
Commits on Sep 17, 2011
  1. @Blaizer

    merge?

    Blaizer authored
  2. @Blaizer
Commits on Sep 18, 2011
  1. @Blaizer
Commits on Sep 30, 2011
  1. @Blaizer
  2. @Blaizer
  3. @Blaizer
  4. @Blaizer
  5. @Blaizer
  6. @Blaizer
  7. @Blaizer
Commits on Dec 13, 2011
  1. @Blaizer
  2. @Blaizer

    merge experimental and master

    Blaizer authored
  3. @Blaizer
  4. @Blaizer

    and now it actually works

    Blaizer authored
Commits on Dec 23, 2011
  1. @Blaizer

    cleaned up SDLx::App. Cleaned up SDLx::Controller and added time and …

    Blaizer authored
    …sleep and made eoq handler modifiable. Added a bunch of tests to controller, still not quite everything is covered. Didn't add anything to app tests, just cleaned them up a little. PODs to come next.
Commits on Dec 24, 2011
  1. @Blaizer
  2. @Blaizer

    Forgot time and sleep in the controller pod, forgot shortcuts for par…

    Blaizer authored
    …am methods and fixed a bit of explanation about param methods.
Commits on Jan 5, 2012
  1. @Blaizer
Commits on Jan 16, 2012
  1. @Blaizer
Commits on Jan 17, 2012
  1. @Blaizer

    a little bit more fixing stuff

    Blaizer authored
  2. @Blaizer
  3. @Blaizer

    SDLx::App tests can_ok updated

    Blaizer authored
  4. @Blaizer

    SDLx::App docs synopsis

    Blaizer authored
  5. @Blaizer

    SDLx::App docs description

    Blaizer authored
  6. @Blaizer
  7. @Blaizer
  8. @Blaizer
Commits on Jan 25, 2012
  1. @Blaizer
Commits on Jan 29, 2012
  1. @ioanrogers

    Make SDLx::Music match the docs: data returns hashref with no args, a…

    ioanrogers authored
    …nd play can be called with $name
Commits on Jan 30, 2012
  1. @Blaizer

    SDLx::App docs for init

    Blaizer authored
  2. @Blaizer

    SDLx::App screen_size

    Blaizer authored
  3. @FROGGS

    Merge pull request #213 from ioanrogers/patch-1

    FROGGS authored
    Make SDLx::Music match the docs
  4. @Blaizer
  5. @Blaizer

    fix for previous commit

    Blaizer authored
Commits on Jan 31, 2012
  1. @Blaizer
  2. @Blaizer
  3. @Blaizer
  4. @Blaizer
  5. @Blaizer
  6. @Blaizer
  7. @Blaizer
  8. @Blaizer
Commits on Feb 2, 2012
  1. @Blaizer

    SDLx::App icon done and documented but transparency doesn't work.

    Blaizer authored
    SDLx::App is just about done now, except for some polish. Needs tests, too...
  2. @Blaizer

    SDLx::Controller stop_handler and its docs.

    Blaizer authored
    Just about finished SDLx::Controller now, too. Needs polish, tests, and... someone to tell me the docs make sense?
Commits on Feb 22, 2012
  1. @FROGGS

    using ogg files

    FROGGS authored
  2. @FROGGS

    added ogg test files

    FROGGS authored
Commits on Mar 10, 2012
  1. @FROGGS
  2. @FROGGS

    fixed bugtracker link

    FROGGS authored
  3. @FROGGS
Commits on Mar 31, 2012
  1. @Blaizer
  2. @Blaizer

    SDLx::Controller stop_handler and changed pause to work better. Fixed…

    Blaizer authored
    … tests. Rewrote docs. Fixed examples to comply
  3. @Blaizer
Commits on Apr 1, 2012
  1. @Blaizer
  2. @Blaizer
Commits on Apr 3, 2012
  1. @Blaizer
  2. @Blaizer

    SDLx::Controller tests for pause, event_handlers and stop_handler

    Blaizer authored
    Also some fixes to the docs and a bunch of fixes and cleanup to the pm
Commits on Apr 6, 2012
  1. @Blaizer
  2. @Blaizer
Commits on Apr 7, 2012
  1. @Blaizer
  2. @Blaizer

    Fix controller tests

    Blaizer authored
Commits on Apr 8, 2012
  1. @Blaizer
Commits on Apr 12, 2012
  1. @Blaizer
  2. @Blaizer
  3. @Blaizer

    Added tests for max_t

    Blaizer authored
Commits on Apr 19, 2012
  1. @FROGGS

    lvalue subs dont return stuff

    FROGGS authored
  2. @FROGGS

    turn MMX on, to be sure

    FROGGS authored
Commits on May 10, 2012
  1. @FROGGS

    platform specific notes by Alex

    FROGGS authored
Commits on May 13, 2012
  1. @mig0

    fix spelling errors in pods

    mig0 authored
  2. @mig0
  3. @FROGGS

    Merge pull request #225 from mig0/master

    FROGGS authored
    Fix most of the screaming spelling errors in pods
Commits on May 16, 2012
  1. @kthakore
Commits on May 22, 2012
  1. @kthakore

    Updated to 2.538

    kthakore authored
Commits on May 26, 2012
  1. @FROGGS @jtpalmer

    platform specific notes by Alex

    FROGGS authored jtpalmer committed
  2. @jtpalmer

    Reverted to 2.537_02

    jtpalmer authored
  3. @jtpalmer

    Merge changelog from 2.538

    jtpalmer authored
  4. @jtpalmer

    Add new changelog entry

    jtpalmer authored
  5. @jtpalmer

    fixed bugtracker link

    jtpalmer authored
  6. @jtpalmer

    Update changelog

    jtpalmer authored
  7. @jtpalmer

    Release 2.540

    jtpalmer authored
Commits on Apr 17, 2013
  1. @bricas
Commits on Aug 27, 2013
  1. @KohaAloha

    added travis buildbot

    KohaAloha authored
Commits on Apr 22, 2014
  1. @FROGGS
  2. @FROGGS

    release 2.542

    FROGGS authored
Commits on May 4, 2014
  1. @FROGGS

    fix segfault when cleaning up MixChunks on windows

    FROGGS authored
    We built the libSDL binaries several years ago, and so it was built
    against an older runtime library (msvcrt.dll).
    Now we build SDL itself against msvcr110.dll for example, and therefore
    allocate on another heap than the free() is taking place, which happens
    in libSDL_mixer itself.
    See: http://stackoverflow.com/questions/23257226/sdl-mixer-mix-freechunk-crashing-on-sample-created-in-memory
  2. @FROGGS

    dev release 2.543_1

    FROGGS authored
Commits on May 11, 2014
  1. @FROGGS
Commits on May 12, 2014
  1. @FROGGS
Commits on May 13, 2014
  1. @FROGGS
Commits on May 14, 2014
  1. @FROGGS

    release 2.544

    FROGGS authored
Commits on Sep 14, 2014
  1. @pinotree

    tests: remove old (and wrong) Hurd workaround

    pinotree authored
    Other than being no more applicable with recent Hurd versions
    (e.g. 0.5), it was working around a bug in TestTool::init, not properly
    handling failures in SDL::init.
    
    Basically it reverts commit 4931c49d1dfdc11aaf86d85db734104a37bef538.
Something went wrong with that request. Please try again.