New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring, add new option, add support for Gentoo Linux #19

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@monsieurp
Contributor

monsieurp commented Mar 14, 2015

Hi Grahram

As discussed with your via email, here's my PR.

Check it out and let me know, should something need to be changed.

Cheers!

Patrice

@plicease

This comment has been minimized.

Member

plicease commented Mar 15, 2015

The first commit does not look right to me. The two if branches are for different environment variables and reset two different arrays.

I think the 64 bit pkgconfig path should come before the 32 bit one. Actually on Solaris and Debian it uses the 64 bit paths instead of the 32 bit ones if the Perl is 64bit. I think that might be better.

Otherwise looks good.

@monsieurp

This comment has been minimized.

Contributor

monsieurp commented Mar 16, 2015

Yeah you're right, sorry about the 1st commit. I got confused with the arrays name :/ I'm going to send you another PR with only the 2 last commits. If you get round to answering my email, please do. :)

@plicease plicease closed this Mar 17, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment