Ikruglov/sysread implementation #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 27, 2014 15:08
WIN32 doesn't support MSG_DONTWAIT, need to swith fh to nonblockng mode manually. For Unix still use MSG_DONTWAIT because of fewer syscalls
As Pavel Shaydo noticed:
The whole __try_read_sock subroutine looks a bit inefficient to me, you are
reading data with MSG_PEEK, just to check if there's any, and then you
throwing it away. Why not save it into {__buf} and avoid reading it again?
|
Took piece of code from previous implementation |
|
will do another pull request based on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issues noticed by Pavel Shaydo in the maillist