Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'get raw transaction data' for Electrumx in bch-api #5

Closed
christroutner opened this issue Jul 30, 2020 · 2 comments · Fixed by #20
Closed

Add 'get raw transaction data' for Electrumx in bch-api #5

christroutner opened this issue Jul 30, 2020 · 2 comments · Fixed by #20
Labels

Comments

@christroutner
Copy link
Contributor

christroutner commented Jul 30, 2020

The scope of this task is to add GET and POST endpoints to bch-api as well as unit and integration tests for a 'get raw transaction data' endpoint for Electrumx.

This is one of series of tasks to port Insomnia REST API to bch-api and bch-js. I've already completed the 'address balance', 'UTXOs', and 'Transaction history' endpoints for you to follow as an example.

For this task, you should submit a PR to the bch-api repository to edit the bch-api/electrumx.js file, in order to add GET and POST endpoints to duplicate the Insomnia /tx/data/{txid} endpoint in bch-api. The verbose option should be set to true by default. You can see how I've implemented the GET and POST endpoints for the first three endpoints. Follow that pattern.

Acceptance Criteria

  • Add GET and POST endpoints to electrumx.js in bch-api.
  • Add api-doc documentation to electrumx.js.
  • Add unit and integration tests for these new endpoints in bch-api.
@christroutner
Copy link
Contributor Author

Resolved with PR #20

@christroutner
Copy link
Contributor Author

🎉 This issue has been resolved in version 1.17.7 🎉

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant