Add get transaction details from Electrum#20
Merged
Conversation
- Add functions for getting a single transaction details or bulk - Add GET and POST routes for these functions - Add tests +mock data for these functions - Add test helper function for stubbing a method for unit tests - Add test helper function for asserting an API error
| // console.log(`_transactionDetailsFromElectrum(): ${JSON.stringify(electrumResponse, null, 2)}`) | ||
|
|
||
| // Pass the error message if ElectrumX reports an error. | ||
| if (electrumResponse instanceof Error) { |
Contributor
There was a problem hiding this comment.
I like the use of instanceof here!
Contributor
|
Great work with this! I love the DRY wrappers. They are a great idea. |
Contributor
|
🎉 This PR is included in version 1.17.7 🎉 Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add functions for getting a single transaction details or bulk
Add GET and POST routes for these functions
Add tests +mock data for these functions
Add test helper function for stubbing a method for unit tests
Add test helper function for asserting an API error
I didn't update the rest of the tests to use these helper functions cause I figured I'd wait for feedback, but imo it makes the code much DRYer.
closes #5