Skip to content

fix(net): stabilize socket handles and reactor paths#4525

Merged
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-net-socket-reactor-20260605
Jun 7, 2026
Merged

fix(net): stabilize socket handles and reactor paths#4525
proggeramlug merged 2 commits into
PerryTS:mainfrom
andrewtdiz:codex/node-compat-net-socket-reactor-20260605

Conversation

@andrewtdiz

Copy link
Copy Markdown
Contributor

Summary

  • register the ext-net socket handle probe so dynamic/static instanceof net.Socket and the net.Stream alias recognize native socket handles
  • route ext-net socket connect and server listen futures through explicit current-thread Tokio runtimes instead of relying on an ambient reactor handle
  • preserve net.Stream === net.Socket behavior while making new net.Stream() instanceof net.Socket match Node

Validation

  • cargo fmt --all -- --check
  • git diff --check
  • ./scripts/check_file_size.sh
  • cargo check -q -p perry-ext-net -p perry-codegen -p perry-runtime
  • PATH=/root/.npm/_npx/bac97da9607b7ef2/node_modules/.bin:$PATH PERRY_NO_AUTO_OPTIMIZE=1 timeout 900 ./run_parity_tests.sh --suite node-suite --module net -> 13 pass / 0 fail / 0 compile fail (test-parity/reports/parity_report_20260605_061937.json)
  • focused reruns: stream-alias, connection-state-limits, create-server-options, listen-port, socket-set-timeout all pass

@proggeramlug proggeramlug force-pushed the codex/node-compat-net-socket-reactor-20260605 branch from bf23958 to 9ed6db1 Compare June 7, 2026 13:20
@proggeramlug proggeramlug merged commit bfe3ac6 into PerryTS:main Jun 7, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants