fix(hir): resolve CJS worker path joins#4815
Merged
proggeramlug merged 2 commits intoJun 9, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__dirnameandimport.metapath fields..replace(...)andpath.default.join(...).node-ptyworker path shape and closure-containedWorkerNewdiscovery.Why
Some CommonJS packages construct worker entry filenames through deterministic path expressions instead of direct literals. One concrete shape is
path.join(__dirname.replace(...), "worker/file.js"). Before this change Perry could not resolve that worker filename, so module collection stopped before the worker module was registered.This does not add native
.nodeaddon loading. In thenode-ptyprobe, this change gets Perry past worker module collection and compilation; executing the compiled probe still reaches the existing native-addon boundary atrequire("./prebuilds/win32-x64/pty.node").Tests
cargo fmt -p perry-hir --checkcargo test -p perry-hir dynamic_import::tests --message-format=short