Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override build date with SOURCE_DATE_EPOCH #2

Merged
merged 2 commits into from Dec 5, 2019

Conversation

@bmwiedemann
Copy link
Contributor

bmwiedemann commented Dec 5, 2019

Allow to override build date with SOURCE_DATE_EPOCH
in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Also switch to UTC to be independent of timezone.

Note: This date call is designed to work with different flavors
of date (GNU, BSD and others).
If only GNU (Linux) support is needed, the patch can be simplified.

This PR was done while working on reproducible builds for openSUSE.

in order to make builds reproducible.
See https://reproducible-builds.org/ for why this is good
and https://reproducible-builds.org/specs/source-date-epoch/
for the definition of this variable.

Also switch to UTC to be independent of timezone.

Note: This date call is designed to work with different flavors
of date (GNU, BSD and others).
If only GNU (Linux) support is needed, the patch can be simplified.

This PR was done while working on reproducible builds for openSUSE.
@deepcode-ci-bot

This comment has been minimized.

Copy link

deepcode-ci-bot bot commented Dec 5, 2019

DeepCode Report (#1ca196)

DeepCode analyzed this pull request.
There are no new issues.

to not add the build date into the produced .png file
to make the package build reproducible.

needed because of declined ImageMagick/ImageMagick#1270
@bmwiedemann bmwiedemann force-pushed the bmwiedemann:master branch from fe80ccb to 1ca196d Dec 5, 2019
@PerryWerneck PerryWerneck merged commit d15da6e into PerryWerneck:master Dec 5, 2019
1 check passed
1 check passed
DeepCode Found no critical issues.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.