Permalink
Commits on Aug 20, 2016
  1. Whitespace

    Change-Id: I22f7d156ac30734824a42d3869dcdf0c7d168521
    committed Aug 20, 2016
  2. Extract large condition to clarify

    Having this in a function makes it much easier to understand both
    the conditional logic and the general flow of the statement which
    uses it.
    
    Change-Id: I9c84c5ffa500f5ffd10a571459ff02f560421d21
    committed Aug 20, 2016
  3. Whitespace

    Change-Id: If0cd508fd085531026bf76cde974364bb1aa6819
    committed Aug 20, 2016
  4. Also require php7.0-zip for testing

    Previously this was part of the core, but now seems to be an extra.
    Since it's only needed in tested mark it as suggested so that we
    don't break the package for people on older platforms.
    
    Change-Id: I6ad81c8f101ff303a593857663ca9c8075f539fa
    committed Aug 20, 2016
  5. Use more standard form environment variable name

    This works around a bug in PHP 7 where hyphenated variable names
    are lost when launching a subprocess via proc_open:
    https://bugs.php.net/bug.php?id=72904
    
    Change-Id: I0737abf41fc88f2f5b30322ef1fb1727ee793555
    committed Aug 20, 2016
Commits on Aug 19, 2016
  1. Default to sorting projects by usage

    This will hopefully make it easier for users to find their desired
    projects among the list.
    
    Change-Id: I5c268d1006daaf36b3b3b71897cc53798a60bd93
    committed Aug 19, 2016
  2. Update the deb for Xenial

    Change-Id: If6b80b0e33be458cc4bd985a475fa960404edea9
    committed Aug 19, 2016
Commits on Jun 24, 2016
  1. Show the file name after saving a new file

    Previously it would continue to show "New File $N" until the user
    switched tabs (causing it to re-render). Force the name to re-render
    once we know it. This still doesn't quite show the right revision
    but is an improvement.
    
    Change-Id: I1bbea5e2b093053a74a7a0b05cb0a7974f730f85
    committed Jun 24, 2016
  2. Show log after saving a new file

    Previously the file was never marked as loaded and so had to be
    re-loaded in order for the revision history to be shown. Mark
    new files as loaded immediately to avoid this issue.
    
    Change-Id: I486bd83bbe25cefff8197bc3a1e1d85d4dd0ff4d
    committed Jun 24, 2016
  3. Avoid using field where a parameter will do

    Change-Id: I8e77963e6e5d63b44f6c143ccb5c5ae702e3771c
    committed Jun 24, 2016
Commits on Apr 16, 2016
  1. Ensure our inline tracking snippet is allowed under CSP

    Use a hash since this code is effectively static. Remove the
    placeholder of the local root since anyone modifying the root
    would also need to update the hash.
    
    Change-Id: I8a72a7eeac76e136188524391efc157e7e8873a1
    committed Apr 16, 2016
  2. Add comment about data: urls in CSP

    Change-Id: I88e6299fe8273465780d4f88116a7d3870c110da
    committed Apr 16, 2016
  3. Allow data: images in our CSP

    We use this to load the team-status images.
    
    Change-Id: Idc170f23c96b7fdb053e2e63daba9d79c7b5cec3
    committed Apr 16, 2016
Commits on Apr 6, 2016
  1. Fix #3158: Add a Content-Security-Policy header

    This should further protect the IDE against various injection-based
    attacks, even though I believe that we're pretty much covered already.
    None of the other potentially useful headers seem useful.
    
    Note that IE doesn't appear to implement this header, though since
    very few of our users are using IE (6% this year) I'm not
    particularly concerned.
    
    Change-Id: If9a174a48502e211f41f736523e103aff4c45ecd
    committed Apr 6, 2016
  2. Fix recordig of autosave access

    Use a url format which Piwik understands; it doesn't appear to like
    having a colon in the partial url.
    
    Change-Id: I0043666c44d4438c54e2807a4ffc314b4a88bc68
    committed Apr 6, 2016
Commits on Apr 3, 2016
  1. Fix issue where having closed files blocked export

    I failed to check for null etab instances (which is how closed files
    are handled, for some reason we don't remove the key) resuling in
    errors if the user had closed a file before exporting a project.
    
    Change-Id: Ie80d92babf8d1c57fe3214a737f67adb9632a28a
    committed Apr 3, 2016
Commits on Apr 2, 2016
  1. Fix #2174: Warn users if exporting projects with local changes

    This doesn't account for files which are closed but have autosaved
    changes, though these seem to be less likely to cause an issue.
    Having detected this issue we focus on one of the files which has
    such changes so that the user can look at what the changes are,
    and/or save the file.
    
    Change-Id: Id4ee65e7347daf4725ead208d7c5fb22120179f3
    committed Apr 2, 2016
  2. Add mechanism to track access to autosaves

    So we can see if this is actually used by anyone.
    
    Change-Id: Iacb006d5054b8b334a29692a5e69cc5b957897bc
    committed Apr 2, 2016
  3. Extract piwik tracking to helper

    Change-Id: I7f9d05b3607bcc1f946363e0a5ce95374e1ebcd9
    committed Apr 2, 2016
  4. Add prefetching of some resources

    This has browsers prefetch the heavy CSS and JS files while still
    on the login page, plus some of the images. Once on the main page
    we also use prefetch to load some of the images we expect to be
    needed later on.
    
    Change-Id: I46e0eb43c06daacf55bace641bf4ad8b3bb7e028
    committed Apr 2, 2016
Commits on Mar 21, 2016
  1. Fix #2103: Add team healthcheck script

    This script has been around for a while, but not anywhere useful.
    Add a new scripts folder and add it so that it's available to all.
    
    The script itself iterates over the master repos for each team,
    looking at the time of the last commit to each. The most recent
    is chosen as a reference and then the values for each team are
    output. The output can be sorted by either TLA or activity date.
    
    Change-Id: I6cb26bf5da9789d2da730615f3f2d3fe90cbd6ff
    committed Mar 21, 2016
Commits on Mar 13, 2016
  1. Add support for using pylint from a Virtualenv

    Anoyingly, pylint doesn't version its dependencies so we're instead
    forced to do this for it by requiring specific versions of the
    packages it uses. Add a requirements file for this and install that
    into the virtualenv we create.
    
    Travis seems to have issues installing the latest version of pylint
    into the main system, so hopefully this will provide some insulation.
    
    Change-Id: I2d1a3541f5e84de9cc7803060cb46957ffc1fde2
    committed Mar 13, 2016
  2. Fix #3173: Cope with paths which start with hyphens

    Place all paths in shells after '--' thus instructing the various
    sub-processes to treat them as paths rather than arguments. This
    doesn't protect things like commit ids, which aren't expected to
    start with hyphens anyway.
    
    Change-Id: I986815cc9a4afba90266335ced9a312a39c05182
    committed Mar 13, 2016
  3. Remove redundant file/new endpoint

    Remove use of it in tests, including moving a test to being just
    for file/put.
    
    Change-Id: Ida4f77cc03d73aa28b87b47d946d7662c0d9b79c
    committed Mar 13, 2016
  4. Remove redundant call

    The putFile method will ensure the file is created anyway.
    
    Change-Id: I121a3cfb4374313b40d06e0b5138b9fbfd7032c0
    committed Mar 13, 2016
  5. Fix test found to be invalid

    Change-Id: Idac053ef399f781a04387ee65e2a8c428835849e
    committed Mar 13, 2016
  6. Remove unused method

    Change-Id: I0bc43927fba69eec9bfa9a3ddbb3d6352f45b58a
    committed Mar 13, 2016
Commits on Feb 18, 2016
  1. Update the lint reference

    This includes:
    - add support for R.power.output
    - add dummy values for R.mode and R.usbkey
    - improve handling of Ruggeduino properties
    
    Change-Id: I0b2c052ce75b17045e8dff8c8366efb60218fbab
    committed Feb 18, 2016
Commits on Jan 23, 2016
  1. Verify the user is in the team before creating a project

    While the actual project creation endpoint already validates this
    explicitly, it feels odd that we'd delay this check within the helper
    (if we were going to do it at all).
    
    Change-Id: Ie8012cab81a908967c5c9929117ccec8371281ec
    committed Jan 23, 2016
Commits on Nov 17, 2015
  1. Make Ctrl+Alt+S not save the file

    While Ctrl+S is a common shortcut for save, adding Alt usually does
    other things (like write polish letters or change the window layout).
    
    Change-Id: Ic2340aab58331ce92b4d62e7f800e4d9642b981a
    committed Nov 17, 2015
  2. Allow Cmd+E to export projects on a Mac

    Previously we only supported Ctrl+E which is more Windows-like.
    
    Change-Id: I1654183ea55a1b1e2cfd4b49a0c210ab11f5715f
    committed Nov 17, 2015
  3. @rspanton

    Update zip-packager to ship overlay sr2016.2

    This overlay includes the latest version of sr-robot.
    rspanton committed Nov 17, 2015
Commits on Nov 14, 2015
  1. Update pipebot to pick up new pipe path

    This moves over to the more recent /var/run/irc/hash-srobo path
    which is a more suitable place for the pipe to be and avoids any
    interference from systemd making things like /tmp be per-process.
    
    Change-Id: I91ff3d62e31fe3c0f13e03a7f137b52894b75273
    committed Nov 14, 2015
Commits on Nov 7, 2015
  1. Note that the team status website should be their own

    Rather than that of their school or college, given that the latter
    will appear on the team status page automatically.
    
    Change-Id: Ib81c3ba1e806b6e5b8904796c2dc0b8e012e6bb4
    committed Nov 7, 2015
Commits on Nov 6, 2015
  1. Update the lint reference to the SR2016 API

    Change-Id: I4675e661482c45c6b7043d78d884eb3b0dedd4a1
    committed Nov 6, 2015