Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate derive for re-exporting proc macros to strum. #57

merged 1 commit into from Aug 16, 2019

Add feature gate derive for re-exporting proc macros to strum. #57

merged 1 commit into from Aug 16, 2019


Copy link

@oxalica oxalica commented Jun 23, 2019

This is a shortcut to use proc macros without manually specifying strum_macros as a dependency, just as serde and many other packages do. So we can simply use use strum::*; (or #[macro_use] extern crate strum; for rustc prior to 1.31.0) to derive.

It is already tested to be compatible with rustc 1.26.0

Maybe more documentation is needed?

Copy link

@Dushistov Dushistov commented Aug 9, 2019

This is great feature, now I have only

extern crate strum_macros;

on the top of my, all other extern crate I removed, thanks to 2018 edition.

@Peternator7 Is anything that should be fixed to make it possible to merge?

Oh, I missed that there is merge conflict, @uHOOCCOOHu can you resolve conflict or if you have no time I can submit separate PR with resolved merge issues?

Copy link
Contributor Author

@oxalica oxalica commented Aug 13, 2019

Rebased now

@Peternator7 Peternator7 merged commit 00397fe into Peternator7:master Aug 16, 2019
1 check passed
Copy link

@Peternator7 Peternator7 commented Aug 16, 2019

This is great!! Sorry for the delay getting to it, but it'll be a great feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants