Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature gate derive for re-exporting proc macros to strum. #57

Merged
merged 1 commit into from Aug 16, 2019
Merged

Add feature gate derive for re-exporting proc macros to strum. #57

merged 1 commit into from Aug 16, 2019

Conversation

@oxalica
Copy link
Contributor

@oxalica oxalica commented Jun 23, 2019

This is a shortcut to use proc macros without manually specifying strum_macros as a dependency, just as serde and many other packages do. So we can simply use use strum::*; (or #[macro_use] extern crate strum; for rustc prior to 1.31.0) to derive.

It is already tested to be compatible with rustc 1.26.0

Maybe more documentation is needed?

@Dushistov
Copy link
Contributor

@Dushistov Dushistov commented Aug 9, 2019

This is great feature, now I have only

#[macro_use]
extern crate strum_macros;

on the top of my lib.rs/main.rs, all other extern crate I removed, thanks to 2018 edition.

@Peternator7 Is anything that should be fixed to make it possible to merge?

Oh, I missed that there is merge conflict, @uHOOCCOOHu can you resolve conflict or if you have no time I can submit separate PR with resolved merge issues?

@oxalica
Copy link
Contributor Author

@oxalica oxalica commented Aug 13, 2019

Rebased now

@Peternator7 Peternator7 merged commit 00397fe into Peternator7:master Aug 16, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Peternator7
Copy link
Owner

@Peternator7 Peternator7 commented Aug 16, 2019

This is great!! Sorry for the delay getting to it, but it'll be a great feature.

@oxalica oxalica deleted the oxalica:feature-derive branch Aug 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants