Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply serialize_all casing to get_serializations #84

Merged
merged 4 commits into from Feb 10, 2020

Conversation

@t-mw
Copy link
Contributor

@t-mw t-mw commented Feb 7, 2020

I'm not sure if this is intentional, but it seems to make sense to convert case for get_serializations. When to_string is already being used for display you may still want to use the automatic case conversion for serialization.

@Peternator7
Copy link
Owner

@Peternator7 Peternator7 commented Feb 8, 2020

I'd agree it seems more consistent. Would you mind adding a note to the changelog as well?

t-mw added 2 commits Feb 10, 2020
@t-mw
Copy link
Contributor Author

@t-mw t-mw commented Feb 10, 2020

Ok great. Sure, I've added the note.

@Peternator7 Peternator7 merged commit 043b60f into Peternator7:master Feb 10, 2020
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@Peternator7
Copy link
Owner

@Peternator7 Peternator7 commented Feb 10, 2020

Merged! Thanks for the fix :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants