Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused Qt modules from AppImage #132

Merged
merged 14 commits into from Oct 6, 2018

Conversation

@TheAssassin
Copy link
Contributor

TheAssassin commented Sep 30, 2018

Part of #93.

@TheLastProject

This comment has been minimized.

Copy link
Member

TheLastProject commented Sep 30, 2018

[appimage/stderr] Desktop file not found, aborting
ERROR: Failed to run plugin: appimage 
@TheAssassin TheAssassin force-pushed the TheAssassin:optimize-appimage-size branch 4 times, most recently from 8c56b8a to 5ce5c25 Sep 30, 2018
@TheAssassin

This comment has been minimized.

Copy link
Contributor Author

TheAssassin commented Sep 30, 2018

Seems like a Travis induced issue. The build of my fork on Travis is green. Will retry perhaps tomorrow.

@TheLastProject

This comment has been minimized.

Copy link
Member

TheLastProject commented Oct 2, 2018

Seems I may have broken it somehow anyway. Can you merge master into this branch?

@TheAssassin TheAssassin force-pushed the TheAssassin:optimize-appimage-size branch 2 times, most recently from e6801f6 to 4d7a028 Oct 3, 2018
@TheAssassin TheAssassin force-pushed the TheAssassin:optimize-appimage-size branch from 6d64235 to 12cab4f Oct 3, 2018
@TheAssassin

This comment has been minimized.

Copy link
Contributor Author

TheAssassin commented Oct 6, 2018

For some reason, using appimagetool directly works. I'd say, we've invested enough time into this PR. Let's keep it that way.

@TheLastProject

This comment has been minimized.

Copy link
Member

TheLastProject commented Oct 6, 2018

I sadly cannot test this completely, as I have SSL-related issues:

qt.network.ssl: QSslSocket: cannot resolve CRYPTO_num_locks                                                                                                                 
qt.network.ssl: QSslSocket: cannot resolve CRYPTO_set_id_callback                                                                                                           
qt.network.ssl: QSslSocket: cannot resolve CRYPTO_set_locking_callback
qt.network.ssl: QSslSocket: cannot resolve ERR_free_strings
qt.network.ssl: QSslSocket: cannot resolve EVP_CIPHER_CTX_cleanup
qt.network.ssl: QSslSocket: cannot resolve EVP_CIPHER_CTX_init
qt.network.ssl: QSslSocket: cannot resolve sk_new_null
qt.network.ssl: QSslSocket: cannot resolve sk_push
qt.network.ssl: QSslSocket: cannot resolve sk_free
qt.network.ssl: QSslSocket: cannot resolve sk_num
qt.network.ssl: QSslSocket: cannot resolve sk_pop_free
qt.network.ssl: QSslSocket: cannot resolve sk_value
qt.network.ssl: QSslSocket: cannot resolve SSL_library_init
qt.network.ssl: QSslSocket: cannot resolve SSL_load_error_strings
qt.network.ssl: QSslSocket: cannot resolve SSL_get_ex_new_index
qt.network.ssl: QSslSocket: cannot resolve SSLv23_client_method
qt.network.ssl: QSslSocket: cannot resolve SSLv23_server_method
qt.network.ssl: QSslSocket: cannot resolve X509_STORE_CTX_get_chain
qt.network.ssl: QSslSocket: cannot resolve OPENSSL_add_all_algorithms_noconf
qt.network.ssl: QSslSocket: cannot resolve OPENSSL_add_all_algorithms_conf
qt.network.ssl: QSslSocket: cannot resolve SSLeay
qt.network.ssl: Incompatible version of OpenSSL
qt.network.ssl: QSslSocket: cannot call unresolved function SSLv23_client_method
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_CTX_new
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_library_init
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function SSLv23_client_method
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_CTX_new
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_library_init
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function SSLv23_client_method
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_CTX_new
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_library_init
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function SSLv23_client_method
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_CTX_new
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_library_init
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function SSLv23_client_method
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_CTX_new
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_library_init
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function SSLv23_client_method
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_CTX_new
qt.network.ssl: QSslSocket: cannot call unresolved function SSL_library_init
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error
qt.network.ssl: QSslSocket: cannot call unresolved function ERR_get_error

However, these are not introduced by changes in this pull request, and everything I could test works, so I will merge this.

@TheLastProject TheLastProject merged commit cf62c56 into Pext:master Oct 6, 2018
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.