Phaeodaria

  • Joined on

Organizations

@xbmc
@Phaeodaria
@Phaeodaria
Phaeodaria commented on pull request xbmc/xbmc#6575
@Phaeodaria

Besides the malloc/free pattern this change looks good to me. Instead of free/malloc I would have preferred an std::vector.

Phaeodaria commented on commit xbmc/xbmc@d9962077a4
@Phaeodaria

and if (!eglChooseConfig(eglDisplay, attributes, eglConfigs.data(), numConfigs, &numConfigs)) here

Phaeodaria commented on commit xbmc/xbmc@d9962077a4
@Phaeodaria

I would have preferred std::vector eglConfigs(numConfigs) here.

Phaeodaria commented on commit xbmc/xbmc@df343f375e
@Phaeodaria

I'm wondering, wouldn't it be more efficient to use the range [0,0][1,height] of the texture instead of [0,0][1,1]? One could use floor(coord.y) to…

Phaeodaria commented on commit xbmc/xbmc@df343f375e
@Phaeodaria

OffsetU.y = OffsetV.y. Why compute the value twice? If the shader designed to support NV12 with UV side by side in the same texture? If not UV will…

Phaeodaria commented on commit xbmc/xbmc@df343f375e
@Phaeodaria

m_step/2.0, m_fieldm_step and 2m_step are constants. It might be more efficient to pass them directly to the shader.

Phaeodaria commented on commit xbmc/xbmc@df343f375e
@Phaeodaria

I fear that this will have a negative impact on battery life and performance on most devices. Unless those values are non-neutral in most cases the…