New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot install ACF Pro 5.3.10 #4

Closed
jamiechong opened this Issue Jul 19, 2016 · 5 comments

Comments

Projects
None yet
3 participants
@jamiechong
Copy link

jamiechong commented Jul 19, 2016

The composer install fails with this error.
[UnexpectedValueException] The version constraint of advanced-custom-fields/advanced-custom-fields-pro should be exact (with 3 or 4 digits). Invalid version string "5.3.10"

The problem looks to be an issue with your regex one Line 187 of Plugin.php

jamiechong referenced this issue Jul 19, 2016

Allow exact versions with 3 or 4 digits (#3)
* Allow exact versions with 3 or 4 digits

ACF PRO are sometimes released as 4 digit version numbers (e.g.
5.3.8.1). The validateVersion regex needs to be updated to account for
that scenario as well.

Fixes #2

* Update README to reflect new valid versions
@PhilippBaschke

This comment has been minimized.

Copy link
Owner

PhilippBaschke commented Jul 20, 2016

Thank you @jamiechong. Fix is on the way 😊

@Rhymes2k

This comment has been minimized.

Copy link

Rhymes2k commented Aug 6, 2016

Same Error still occurs with pre-release versions e.g. "5.4.0-RC1". Or is there another way to require stable-tags? see https://getcomposer.org/doc/04-schema.md#version

@PhilippBaschke

This comment has been minimized.

Copy link
Owner

PhilippBaschke commented Aug 6, 2016

@Rhymes2k Good call. I will add the RC part.

What do you mean by "other way to require stable-tags"? Do you think I should allow all versions that are allowed according to Composer? But it seems like that 5.3.9.1 is not allowed by Composer (but ACF might use it).

@Rhymes2k

This comment has been minimized.

Copy link

Rhymes2k commented Aug 6, 2016

As far as I know ACF sticks to 3 digit versioning - at least since v5.
Would it harm to ease the restrictions (or even remove them)? Wouldn't composer just complain about the package url not being reachable if the version doesnt exist?
I can't think of any perfect solution here until Elliot adds composer support to acf pro himself.

edit: i'd say allowing all versions allowed by Composer's JSON schema (for now) couldn't hurt.

@PhilippBaschke

This comment has been minimized.

Copy link
Owner

PhilippBaschke commented Aug 10, 2016

@Rhymes2k I'll investigate the composer error messages. If they are fairly explanatory, I'll consider removing the constraint altogether. It seems a little to brittle (I got surprised by new versions twice now). 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment