New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with plugin Hirak/prestissimo #20

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
8 participants
@mickaelperrin
Copy link

mickaelperrin commented Aug 16, 2017

When using this plugin in conjunction with hirak/prestissimo, the download of acf-pro fails because the custom RemoteFileSystem is overwritten. In order to get it working, we should ensure that this plugins runs after hirak/prestissimo.
As both are running with a priority set to 0, setting this one to -1 resolves the issue.

Doesn't work with plugin Hirak/prestissimo
When using this plugin in conjunction with hirak/prestissimo, the download of acf-pro fails because the custom RemoteFileSystem is overwritten. In order to get it working, we should ensure that this plugins runs *after* hirak/prestissimo.
As both are running with a priority set to 0, setting this one to -1 resolves the issue.
@partounian

This comment has been minimized.

Copy link

partounian commented Sep 11, 2017

Can we please get this integrated?

@PhilippBaschke

This comment has been minimized.

Copy link
Owner

PhilippBaschke commented Sep 12, 2017

Thank you @mickaelperrin for your research and for submitting a pull request to solve the issue! ☺️
Sorry for the late answer, I was pretty busy lately 😞
Would you be so kind to adapt the failing test to reflect the new requirements? Let me know if you need help with that (the PHPUnit Manual can be handy resource).

Thank you again ☺️

@tucq88

This comment has been minimized.

Copy link

tucq88 commented Sep 13, 2017

Can't wait until this being merged T_T

@partounian

This comment has been minimized.

Copy link

partounian commented Oct 13, 2017

I suggest someone forks this project and updates it

@tucq88

This comment has been minimized.

Copy link

tucq88 commented Oct 14, 2017

Could you merge this @PhilippBaschke ?

@cooperaj

This comment has been minimized.

Copy link

cooperaj commented Feb 9, 2018

Just had to remove prestissimo for this one.

@strarsis

This comment has been minimized.

Copy link

strarsis commented Apr 14, 2018

@PhilippBaschke: +1
Also had an issue with hirak/prestissimo. After uninstalling it works.

@strarsis

This comment has been minimized.

Copy link

strarsis commented Jul 12, 2018

@PhilippBaschke: Are there plans for merging this in the near future? Just had this issue again.

@david-treblig

This comment has been minimized.

Copy link

david-treblig commented Jul 12, 2018

Same. Get it every two weeks everytime I start a new project... 😭

@strarsis

This comment has been minimized.

Copy link

strarsis commented Jul 12, 2018

@randmanrjr: Have you (still) write access to this repository? Could you merge this in
(and publish a new release to packagist)?

@randmanrjr

This comment has been minimized.

Copy link
Contributor

randmanrjr commented Jul 13, 2018

@strarsis I don't have write access to this repository. In the past, I made a small contribution via a pull request.

@strarsis

This comment has been minimized.

Copy link

strarsis commented Aug 9, 2018

Strange, I just tried it with hirak/prestissimo installed and it worked. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment