New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Scopes get losts when disable/reenable #136

Closed
PhilippC opened this Issue Nov 25, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@PhilippC
Owner

PhilippC commented Nov 25, 2017

reported by mail:

Something with the same results can be replicated following way:
(screens attached)

  1. plugin is enabled, has requested access scope, works ok

  2. KP2A -> Plug-ins -> InputStick Plugin (shows enabled) -> shows Scopes -> Disable
    (ACTION_REVOKE_ACCESS is received by the plugin)

  3. go back -> InputStick Plugin (shows disabled) -> check Enable
    (ACTION_RECEIVE_ACCESS is received)

  4. plugin gets "enabled" but it has no access scopes now. So as a result it no longer works.

next time "Plug-ins" is opened, plugin receives ACTION_REVOKE_ACCESS, still it will be displayed as enabled. If you go back one more time it will now properly show "Disabled" status

I've taken a look at source code here:
https://github.com/PhilippC/keepass2android/blob/master/src/keepass2android/pluginhost/PluginDatabase.cs

so, when plugin gets disabled:
SetEnabled(string pluginPackage, false)
all scopes are replaced with an empty list, which is then returned once the plugin gets re-enabled, what would explain missing scopes.

@PhilippC PhilippC added the bug label Nov 25, 2017

@PhilippC PhilippC added this to the 1.05 milestone Nov 25, 2017

@PhilippC PhilippC closed this in 135f261 Nov 27, 2017

@PhilippC PhilippC modified the milestones: 1.05, 1.03 Nov 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment