Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #62 Added polar graph support #64

Open
wants to merge 2 commits into
base: master
from

Conversation

@ryananeff
Copy link

commented Sep 25, 2018

Changed the base adjustment coordinate system from Axes coordinates to display coordinates, which allows polar graph support (or any other coordinate system in the future).

@Phlya

This comment has been minimized.

Copy link
Owner

commented Sep 25, 2018

@ryananeff

This comment has been minimized.

Copy link
Author

commented Sep 25, 2018

No problem!

@Phlya

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2018

From a quick glans it looks good, I'll also try to run the examples to see whether there are any problems.
Nice polar plot example! Can you add it to the main example notebook, so it gets pulled into the docs as well?

The only thought I had was that with polar plots the text can go outside of the round axes, since we only operate on it's bbox... I don't know how to prevent this, but I also never work with polar plots, perhaps you might have an idea?

@Phlya

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2018

I think it should be possible to check whether any corner of a bbox is further away from the centre than the radius of the axes, and force it inside, if so. But we'd need to check whether the axes are polar or cartesian, since we don't want this behaviour in the latter case.

@Phlya

This comment has been minimized.

Copy link
Owner

commented Sep 26, 2018

Alternatively, labels a bit outside of the axes might be OK for polar plots, but they shouldn't overlap ticklabels then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.