Adjust recruitable status on team member discharge#2248
Conversation
TaranDahl
added
Needs testing
⚙️T1
📝 WalkthroughWalkthroughThis PR implements configurable control over the ChangesRecruitable Status on Team Member Discharge
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Infer (1.2.0)src/Ext/TeamType/Body.cppIn file included from src/Ext/TeamType/Body.cpp:1: ... [truncated 2200 characters] ... t.add_method in file "src/clang/cFrontend_decl.ml" (inlined), line 54, characters 4-52 src/Ext/Rules/Body.cppIn file included from src/Ext/Rules/Body.cpp:1: ... [truncated 2200 characters] ... in file "src/clang/cFrontend_decl.ml" (inlined), line 54, characters 4-52 src/Misc/Hooks.BugFixes.cppsrc/Misc/Hooks.BugFixes.cpp:1:10: fatal error: 'AircraftTrackerClass.h' file not found ... [truncated 2200 characters] ... e "src/clang/cTrans.ml", line 4784, characters 10-1023
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/locale/zh_CN/LC_MESSAGES/AI-Scripting-and-Mapping.po (1)
6-6:⚠️ Potential issue | 🟠 Major | ⚡ Quick winClear the catalog-level
fuzzymarker after updating this translation.The file was updated for new source strings, so leaving
#, fuzzykeeps the catalog marked as needing review.Proposed fix
-#, fuzzyAs per coding guidelines, "update
.poentries marked fuzzy when English source docs change".🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/locale/zh_CN/LC_MESSAGES/AI-Scripting-and-Mapping.po` at line 6, The catalog entry still has the `#, fuzzy` marker which must be cleared after updating translations; open the PO file and remove the `#, fuzzy` flag (or change it to `#, reviewed` per your workflow) for the updated message in AI-Scripting-and-Mapping.po, ensure the translated string is correct and up-to-date with the English source, then save and run your usual PO validation/compilation (e.g., msgfmt or your CI linter) so the catalog is no longer marked as needing review.Source: Coding guidelines
🧹 Nitpick comments (1)
docs/locale/zh_CN/LC_MESSAGES/CREDITS.po (1)
2485-2486: 💤 Low valueOptional: Consider terminology refinement for "discharge"
The translation "小队成员解散时调整可招募性" is understandable and conveys the meaning. However, "解散" typically means "disband" (implying the entire team dissolves), while the English "discharge" refers to removing individual members from a team.
For slightly better precision, consider:
- "小队成员释放时调整可招募性" (using "释放" = release)
- "调整解散小队成员的可招募性" (restructured)
The current translation is acceptable, so this is purely an optional refinement for terminology precision.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/locale/zh_CN/LC_MESSAGES/CREDITS.po` around lines 2485 - 2486, The msgid "Adjust recruitable status on team member discharge" currently has msgstr "小队成员解散时调整可招募性" which uses "解散" (disband) and may misrepresent "discharge" as removing an individual; update the translation in this PO entry (the msgstr for that msgid) to a more precise option such as "小队成员释放时调整可招募性" or "调整解散小队成员的可招募性" (choose one) to better reflect removing a member rather than disbanding the whole team.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/AI-Scripting-and-Mapping.md`:
- Line 986: Update the inline comment for the INI key
IsDischargedMemberAutocreateRecruitable to correct the grammar: change "default
to" to "defaults to" so the comment reads "defaults to [General] ->
IsDischargedMemberAutocreateRecruitable"; locate the line containing
IsDischargedMemberAutocreateRecruitable and replace the phrase accordingly.
In `@src/Misc/Hooks.BugFixes.cpp`:
- Line 3221: The statement calling TeamTypeExt::ExtMap.Find is missing a
terminating semicolon; update the line that reads "const auto pTeamTypeExt =
TeamTypeExt::ExtMap.Find(pTeam->Type)" (referencing pTeam and pTeamTypeExt) to
end with a semicolon so it becomes a valid C++ statement and the file compiles.
---
Outside diff comments:
In `@docs/locale/zh_CN/LC_MESSAGES/AI-Scripting-and-Mapping.po`:
- Line 6: The catalog entry still has the `#, fuzzy` marker which must be
cleared after updating translations; open the PO file and remove the `#, fuzzy`
flag (or change it to `#, reviewed` per your workflow) for the updated message
in AI-Scripting-and-Mapping.po, ensure the translated string is correct and
up-to-date with the English source, then save and run your usual PO
validation/compilation (e.g., msgfmt or your CI linter) so the catalog is no
longer marked as needing review.
---
Nitpick comments:
In `@docs/locale/zh_CN/LC_MESSAGES/CREDITS.po`:
- Around line 2485-2486: The msgid "Adjust recruitable status on team member
discharge" currently has msgstr "小队成员解散时调整可招募性" which uses "解散" (disband) and
may misrepresent "discharge" as removing an individual; update the translation
in this PO entry (the msgstr for that msgid) to a more precise option such as
"小队成员释放时调整可招募性" or "调整解散小队成员的可招募性" (choose one) to better reflect removing a
member rather than disbanding the whole team.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6baa07e7-22f2-45f1-ac39-ef780c23ea31
📒 Files selected for processing (13)
CREDITS.mdPhobos.vcxprojdocs/AI-Scripting-and-Mapping.mddocs/Whats-New.mddocs/locale/zh_CN/LC_MESSAGES/AI-Scripting-and-Mapping.podocs/locale/zh_CN/LC_MESSAGES/CREDITS.podocs/locale/zh_CN/LC_MESSAGES/Whats-New.posrc/Ext/Rules/Body.cppsrc/Ext/Rules/Body.hsrc/Ext/TeamType/Body.cppsrc/Ext/TeamType/Body.hsrc/Misc/Hooks.BugFixes.cppsrc/Phobos.Ext.cpp
|
Nightly build for this pull request:
This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build. |
|
To Chinese users:
|
2 participants
This is an extension to #2022
Teams
Adjust recruitable status on team member discharge
RecruitableBflag is overwritten by the team'sAreTeamMembersRecruitablesetting. When the unit is discharged from the team, the flag is not restored. The following settings allow a team to reset this flag when discharging its members.[General] → IsDischargedMemberAutocreateRecruitablesets the global default value.[TeamType] → IsDischargedMemberAutocreateRecruitableoverrides the global default for a specific team type.-1), the original game behavior is preserved.In
rulesmd.ini:Summary by CodeRabbit
Release Notes
New Features
Documentation