Fix list widget selection bug #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…done in another list widget before the current list widget has been opened once
plata
reviewed
Dec 23, 2018
| * | ||
| * @param oldSelection The old/previous selection | ||
| */ | ||
| private void updateOldSelection(ListWidgetSelection<E> oldSelection) { |
There was a problem hiding this comment.
Are these methods different for all derived classes? (bit hard to see in the diff)
There was a problem hiding this comment.
Both the DetailsListWidget and the CompactListWidget have the same methods.
The reason is, that I don't want to invest an additional base class for only two concrete derived classes.
plata
approved these changes
Dec 23, 2018
|
To be honest, I didn't quite understand what the issues were in end (in the pr description). |
|
Try the following:
Now you'll see that the first application is not selected in the now open list widget. |
|
Thanks for the explanation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where a list widget (a) doesn't show a selection, if the selection was has been performed in another list widget (b) before (a) has been opened once.