mysql 3 fix #199

Closed
Phorum opened this Issue Jun 11, 2011 · 1 comment

Projects

None yet

1 participant

@Phorum
Phorum commented Jun 11, 2011

I am aware of only 1 line that prevents phorum 5 from being mysql 3.23 compatible.

line 393 in include/mysql.php:

$sql="($sql and status=".PHORUM_STATUS_HOLD.") union ($sql and status=".PHORUM_STATUS_HIDDEN.")";

can be changed to:

$sql= "$sql AND status IN (".PHORUM_STATUS_HOLD.", ".PHORUM_STATUS_HIDDEN.")";

which is also a more efficient query. mysql 3.23 doesn't have a "union" statement.

good luck and thanks for doing a great job!

Erik

Reported by: phorum@kupoday.net
Imported from TRAC: http://trac.phorum.org/ticket/202

@Phorum
Phorum commented Jun 11, 2011

no, this "fix" won't be incorporated.
we don't support mysql3 and phorum-5.1 has even more dependencies on mysql4 with its fulltext search, also its not really a more efficient query.
also in phorum 5.0.x there is a query in the newflags handling which depends on mysql4 (where clause on delete with limit if I remember correctly).

By: ts77

@Phorum Phorum closed this Jun 11, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment