New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue variation color select. #30

Closed
sobujbd opened this Issue Nov 22, 2017 · 9 comments

Comments

Projects
None yet
2 participants
@sobujbd

sobujbd commented Nov 22, 2017

Method 1 / Colorise - Working
Method 2 / Hue - Not Working

On color select horizontalSlider degrees need to be adjust.

@sobujbd sobujbd closed this Nov 22, 2017

@sobujbd sobujbd reopened this Nov 23, 2017

@DylanC

This comment has been minimized.

Show comment
Hide comment
@DylanC

DylanC Nov 23, 2017

Contributor

@sobujbd - What do you mean? Do you have an example?

Contributor

DylanC commented Nov 23, 2017

@sobujbd - What do you mean? Do you have an example?

@sobujbd

This comment has been minimized.

Show comment
Hide comment
@sobujbd

sobujbd Dec 14, 2017

See this as example.
photoflare 2017-12-14 12-02

sobujbd commented Dec 14, 2017

See this as example.
photoflare 2017-12-14 12-02

@DylanC

This comment has been minimized.

Show comment
Hide comment
@DylanC

DylanC Dec 15, 2017

Contributor

@sobujbd - Thanks. I will give this a test. Looks like a possible bug here.

Contributor

DylanC commented Dec 15, 2017

@sobujbd - Thanks. I will give this a test. Looks like a possible bug here.

@DylanC

This comment has been minimized.

Show comment
Hide comment
@DylanC

DylanC Dec 17, 2017

Contributor

@sobujbd - Yes, this is a problem with the current version. Thanks.

Contributor

DylanC commented Dec 17, 2017

@sobujbd - Yes, this is a problem with the current version. Thanks.

@DylanC DylanC added the bug label Dec 17, 2017

@DylanC

This comment has been minimized.

Show comment
Hide comment
@DylanC

DylanC Dec 18, 2017

Contributor

@sobujbd - Just to give you some background on this.

The feature of selecting a custom colour was added as part of a community suggestion.
https://photoflare.io/photofiltre-lx-1-0-1-released/

This is why the degrees do not get updated. I'm not exactly sure how to convert a colour to degrees, as I'm pretty sure the degrees depends upon the slider value and not the actual colour.

Also I think the degrees do not update for custom colour in both colorize and hue variation.

Contributor

DylanC commented Dec 18, 2017

@sobujbd - Just to give you some background on this.

The feature of selecting a custom colour was added as part of a community suggestion.
https://photoflare.io/photofiltre-lx-1-0-1-released/

This is why the degrees do not get updated. I'm not exactly sure how to convert a colour to degrees, as I'm pretty sure the degrees depends upon the slider value and not the actual colour.

Also I think the degrees do not update for custom colour in both colorize and hue variation.

@DylanC

This comment has been minimized.

Show comment
Hide comment
@DylanC

DylanC Dec 21, 2017

Contributor

@sobujbd - I was thinking of changing the degrees label to say "Custom" if you pick a custom colour. How does this sound as a workaround?

Contributor

DylanC commented Dec 21, 2017

@sobujbd - I was thinking of changing the degrees label to say "Custom" if you pick a custom colour. How does this sound as a workaround?

@sobujbd

This comment has been minimized.

Show comment
Hide comment
@sobujbd

sobujbd Dec 21, 2017

You can hide the degrees
or Show an Icon
or Show color code
or Show color name
Or for now 'custom' word.
In 30 px what will be good, do you think?

sobujbd commented Dec 21, 2017

You can hide the degrees
or Show an Icon
or Show color code
or Show color name
Or for now 'custom' word.
In 30 px what will be good, do you think?

@DylanC

This comment has been minimized.

Show comment
Hide comment
@DylanC

DylanC Dec 21, 2017

Contributor

@sobujbd - Yes, I think any option from that list would be good.

Contributor

DylanC commented Dec 21, 2017

@sobujbd - Yes, I think any option from that list would be good.

@DylanC

This comment has been minimized.

Show comment
Hide comment
@DylanC

DylanC Dec 23, 2017

Contributor

Added a fix for this: 6b6fb2a

Contributor

DylanC commented Dec 23, 2017

Added a fix for this: 6b6fb2a

@DylanC DylanC closed this Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment