Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hue variation color select. #30

Closed
sobujbd opened this issue Nov 22, 2017 · 9 comments
Closed

Hue variation color select. #30

sobujbd opened this issue Nov 22, 2017 · 9 comments
Labels
bug

Comments

@sobujbd
Copy link

@sobujbd sobujbd commented Nov 22, 2017

Method 1 / Colorise - Working
Method 2 / Hue - Not Working

On color select horizontalSlider degrees need to be adjust.

@sobujbd sobujbd closed this Nov 22, 2017
@sobujbd sobujbd reopened this Nov 23, 2017
@DylanC
Copy link
Contributor

@DylanC DylanC commented Nov 23, 2017

@sobujbd - What do you mean? Do you have an example?

@sobujbd
Copy link
Author

@sobujbd sobujbd commented Dec 14, 2017

See this as example.
photoflare 2017-12-14 12-02

@DylanC
Copy link
Contributor

@DylanC DylanC commented Dec 15, 2017

@sobujbd - Thanks. I will give this a test. Looks like a possible bug here.

@DylanC
Copy link
Contributor

@DylanC DylanC commented Dec 17, 2017

@sobujbd - Yes, this is a problem with the current version. Thanks.

@DylanC DylanC added the bug label Dec 17, 2017
@DylanC
Copy link
Contributor

@DylanC DylanC commented Dec 18, 2017

@sobujbd - Just to give you some background on this.

The feature of selecting a custom colour was added as part of a community suggestion.
https://photoflare.io/photofiltre-lx-1-0-1-released/

This is why the degrees do not get updated. I'm not exactly sure how to convert a colour to degrees, as I'm pretty sure the degrees depends upon the slider value and not the actual colour.

Also I think the degrees do not update for custom colour in both colorize and hue variation.

@DylanC
Copy link
Contributor

@DylanC DylanC commented Dec 21, 2017

@sobujbd - I was thinking of changing the degrees label to say "Custom" if you pick a custom colour. How does this sound as a workaround?

@sobujbd
Copy link
Author

@sobujbd sobujbd commented Dec 21, 2017

You can hide the degrees
or Show an Icon
or Show color code
or Show color name
Or for now 'custom' word.
In 30 px what will be good, do you think?

@DylanC
Copy link
Contributor

@DylanC DylanC commented Dec 21, 2017

@sobujbd - Yes, I think any option from that list would be good.

@DylanC
Copy link
Contributor

@DylanC DylanC commented Dec 23, 2017

Added a fix for this: 6b6fb2a

@DylanC DylanC closed this Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.