Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shows update available if version online is older #35

Closed
DylanC opened this issue Dec 19, 2017 · 1 comment
Closed

Shows update available if version online is older #35

DylanC opened this issue Dec 19, 2017 · 1 comment
Labels

Comments

@DylanC
Copy link
Contributor

@DylanC DylanC commented Dec 19, 2017

The docs show compare to return int:
https://doc.qt.io/qt-5/qversionnumber.html#compare

However the code currently uses a bool value. Meaning it will return true even for older versions online.

@DylanC DylanC added the bug label Dec 19, 2017
@DylanC
Copy link
Contributor Author

@DylanC DylanC commented Dec 21, 2017

Fixed with 3369340

Loading

@DylanC DylanC closed this Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant