Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect type hint #45

Closed
g105b opened this issue Jul 12, 2019 · 2 comments
Closed

Incorrect type hint #45

g105b opened this issue Jul 12, 2019 · 2 comments

Comments

@g105b
Copy link
Member

g105b commented Jul 12, 2019

Session data can contain anything, not just strings. This typehint confuses IDEs:

/** @var string[] */

@g105b
Copy link
Member Author

g105b commented Nov 26, 2019

Just got caught out by this again...

g105b added a commit that referenced this issue Nov 26, 2019
@g105b
Copy link
Member Author

g105b commented Nov 26, 2019

... so I fixed it.

@g105b g105b closed this as completed in 3e42dcd Nov 26, 2019
g105b added a commit that referenced this issue Feb 27, 2020
* Correct typehint, closes #45

* Implement SessionContainer and SessionArrayWrapper
Closes #63
g105b added a commit that referenced this issue Apr 10, 2020
* Correct typehint, closes #45

* Implement session destruction when failure to start
Closes #66
g105b added a commit that referenced this issue Feb 2, 2023
* Correct typehint, closes #45

* Implement session destruction when failure to start
Closes #66

* Simplify destroying failed session

* Allow only 1 failed start of session

* fix: off by one error - caught by phpstan
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant