Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compat] Allow Chiseled armour to render when worn by Custom NPCs #17

Closed
thephoenixlodge opened this Issue Sep 14, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@thephoenixlodge
Copy link

thephoenixlodge commented Sep 14, 2017

Currently placing chiseled armour in a an NPCs armour slots won't render it on the NPC. After speaking with Noppes (author of CNPCs), it's apparently a matter of allowing the armour to render on zombies.

@Phylogeny

This comment has been minimized.

Copy link
Owner

Phylogeny commented Oct 15, 2017

Vanilla zombies? Because it should render on them already (if it doesn't for you, let me know). If so, not only does that indicate it should already work, but it seems odd to me that it would; chiseled armor is rendered via a render layer that is separately added to the renderers of specific entity classes registered with the render manager. Unless he's importing copies of the render layers of the vanilla zombie class's renderer, I don't see how merely rendering on vanilla zombies would cause rendering on his entities.

If not, I don't see anything in CustomNPCsAPI for adding render layers to any of his entities, and his mod is closed source.

@KathySharks

This comment has been minimized.

Copy link

KathySharks commented Oct 16, 2017

Well, a bit of fiddling revealed the following behaviour. [Tested in 1.12.2 most recent Forge]
image

Under the guise of typical mobs it works fine, but not the default NPC entity. Because the default NPC entity isn't working, the Puppet 'job' implemented by CustomNPCs (Which allows the pose seen above), does not apply to mobs and therefor does not allow one to pose them while wearing Chiseled Armor.

It seems that the NPC entity from Custom NPCs, is not referred to as Zombie internally.
My guess is that it's another entity referred to in the API.

Contacting Noppes directly may yield better answers. I've opened an issue on the mod's curseforge page. https://minecraft.curseforge.com/projects/custom-npcs/issues/1926

Phylogeny added a commit that referenced this issue Aug 1, 2018

Allowed the default chiseled armor model to respect part scales and p…
…ositions set by Custom NPCs, and prevented crashing when MPM and/or CNPCs is not installed. #17 #21
@Phylogeny

This comment has been minimized.

Copy link
Owner

Phylogeny commented Aug 8, 2018

This should be fixed as of v3.3.0. Let me know if you run into any problems.

@Phylogeny Phylogeny closed this Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.