Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MPM and Extra Bit manipulation #21

Closed
Greenjoe12345 opened this Issue Jan 13, 2018 · 8 comments

Comments

Projects
None yet
2 participants
@Greenjoe12345
Copy link

Greenjoe12345 commented Jan 13, 2018

The rendering of chiseled armor is kinda broken with more player models

the hat and arm and leg pieces do not properly move with those body parts

the armor is also too small when placed on the player, and has to be adjusted and moved to be in the right place

also, one more thing, the default diamond armor styled stuff seems to work, it moves with the head, but addding a custom chisled thing makes it not move with the head

@Greenjoe12345

This comment has been minimized.

Copy link
Author

Greenjoe12345 commented Jul 29, 2018

So once it updates on curseforge it'll be fixed?

@Phylogeny

This comment has been minimized.

Copy link
Owner

Phylogeny commented Jul 29, 2018

I'm looking into adding one other mod integration right now, but yes, the next release will have this change. It should be fixed.

@Greenjoe12345

This comment has been minimized.

Copy link
Author

Greenjoe12345 commented Jul 29, 2018

Nice :) what other mod?

@Phylogeny

This comment has been minimized.

Copy link
Owner

Phylogeny commented Jul 29, 2018

CNPCs #17

@Greenjoe12345

This comment has been minimized.

Copy link
Author

Greenjoe12345 commented Jul 29, 2018

Looking forward to the update coming out 😄

Phylogeny added a commit that referenced this issue Aug 1, 2018

Phylogeny added a commit that referenced this issue Aug 1, 2018

Allowed the default chiseled armor model to respect part scales and p…
…ositions set by Custom NPCs, and prevented crashing when MPM and/or CNPCs is not installed. #17 #21
@Phylogeny

This comment has been minimized.

Copy link
Owner

Phylogeny commented Aug 1, 2018

Alright, well unexpectedly, making the static/default chiseled armor model render properly with MPM and CNPCs ended up being significantly harder than doing so for the custom chiseled armor items/blocks rendering in their own layer, but I believe I've got it now. I'll do more testing, but it does finally seem solid. It shouldn't be too much longer.

@Greenjoe12345

This comment has been minimized.

Copy link
Author

Greenjoe12345 commented Aug 1, 2018

Alright, Cool!

@Phylogeny

This comment has been minimized.

Copy link
Owner

Phylogeny commented Aug 8, 2018

This should be fixed as of v3.3.0. Let me know if you run into any problems.

@Phylogeny Phylogeny closed this Aug 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.