Add qemu-arm-static when chroot on non-arm platform #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canihavesomecoffee
requested changes
May 27, 2019
install/install.sh
Outdated
| @@ -95,7 +95,7 @@ fi | |||
| server_ip=`dig +short myip.opendns.com @resolver1.opendns.com` | |||
| read -e -p "Server IP: " -i "${server_ip}" config_server_ip | |||
| read -e -p "Server interface (SSL): " -i "443" config_server_port | |||
| read -e -p "Application root (if not a whole (sub)domain, enter the path. None if whole (sub)domain): " -i "None" config_application_root | |||
| read -e -p "Application root (if not a whole (sub)domain, enter the path. None if whole (sub)domain): " -i "'/'" config_application_root | |||
There was a problem hiding this comment.
I thought (at least under the Flask version I used) that it should be None, as we'd use a full domain (e.g. canihavesome.coffee) and not a subdirectory... Did it change?
There was a problem hiding this comment.
The web page continues to jump back to auth/login if the application_root is None. Before I find any other supportive material, let's leave that to None.
|
Hello @VertexC, Thank you for updating the PR! Great work! I discovered no PEP8 issues in this Pull Request. 🥇 Comment last updated at 2019-06-01 20:37:52 UTC |
bin/create_image.sh
Outdated
| @@ -68,13 +68,23 @@ cp -r "${DIR}/../../client" /mnt/tmp/usr/src/client >> "${LOG}" 2>&1 | |||
| echo "${3}" > /tmp/profile.json | |||
| mv /tmp/profile.json /mnt/tmp/usr/src/client/honeypot_profile.json | |||
| cp -r "${DIR}/../pipot/services" /mnt/tmp/usr/src/client/pipot >> "${LOG}" 2>&1 | |||
| cpuArch=$(python ${DIR}/getCpuArch.py) | |||
There was a problem hiding this comment.
Is there a reason why you use python instead of directly calling it here in bash?
|
Close as PR #24 add the same feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image boots on raspberry3B model while failed on raspberry3+B.