Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose `collect` method in `Loader` #11

Merged
merged 3 commits into from Jan 3, 2020
Merged

Conversation

@hisener
Copy link
Member

hisener commented Jan 1, 2020

This PR target #9.

@hisener hisener requested review from Stephan202 and Mordavolt Jan 1, 2020
@@ -65,6 +66,11 @@ public void next(Record record) {
return get().stream();
}

/** Returns all objects loaded by this loader. */

This comment has been minimized.

Copy link
@Stephan202

Stephan202 Jan 1, 2020

Member
Suggested change
/** Returns all objects loaded by this loader. */
/** Collects and then returns all objects loaded by this loader. */

The Collector may do anything, so I think that's worth calling out.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 1, 2020

Codecov Report

Merging #11 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #11      +/-   ##
===========================================
+ Coverage     89.16%   89.2%   +0.03%     
- Complexity      117     118       +1     
===========================================
  Files             8       8              
  Lines           277     278       +1     
  Branches         23      23              
===========================================
+ Hits            247     248       +1     
  Misses            2       2              
  Partials         28      28
Impacted Files Coverage Δ Complexity Δ
src/main/java/tech/picnic/jolo/Loader.java 100% <100%> (ø) 14 <3> (+1) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31546cf...95f88e3. Read the comment docs.

Copy link

Mordavolt left a comment

Great, thanks!

@hisener

This comment has been minimized.

Copy link
Member Author

hisener commented Jan 1, 2020

Rebased.

@hisener hisener force-pushed the hsener/expose-collect-in-loader branch from e4999ea to 1652396 Jan 1, 2020
@Stephan202

This comment has been minimized.

Copy link
Member

Stephan202 commented Jan 2, 2020

Suggested commit message:

Introduce `Loader#collect(Collector<? super T, A, R> collector)` (#11)
@Stephan202 Stephan202 force-pushed the hsener/expose-collect-in-loader branch from 1652396 to 95f88e3 Jan 2, 2020
@Stephan202 Stephan202 changed the base branch from hsener/expose-pair to master Jan 2, 2020
@Stephan202

This comment has been minimized.

Copy link
Member

Stephan202 commented Jan 2, 2020

Rebased; PR now targets master.

@Stephan202 Stephan202 merged commit f9fd5e1 into master Jan 3, 2020
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 89.16%)
Details
codecov/project 89.2% (+0.03%) compared to 31546cf
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Stephan202 Stephan202 deleted the hsener/expose-collect-in-loader branch Jan 3, 2020
@Stephan202 Stephan202 added this to the 0.0.2 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.