Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Javadoc generation #12

Merged
merged 1 commit into from Jan 3, 2020
Merged

Conversation

@Stephan202
Copy link
Member

Stephan202 commented Jan 3, 2020

An earlier workaround for jooq-codegen-maven caused maven-javadoc-plugin to skip Immutables-generated code.

This fix can be tested by running the javadoc:jar@generate-javadoc-jar goal before and after the change.

An earlier workaround for the `jooq-codegen-maven` caused the
`maven-javadoc-plugin` to skip Immutables-generated code.
@Stephan202 Stephan202 requested a review from hisener Jan 3, 2020
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jan 3, 2020

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #12   +/-   ##
========================================
  Coverage      89.2%   89.2%           
  Complexity      118     118           
========================================
  Files             8       8           
  Lines           278     278           
  Branches         23      23           
========================================
  Hits            248     248           
  Misses            2       2           
  Partials         28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fd5e1...c3c4dd3. Read the comment docs.

@hisener
hisener approved these changes Jan 3, 2020
@Stephan202 Stephan202 merged commit 68627c0 into master Jan 3, 2020
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing f9fd5e1...c3c4dd3
Details
codecov/project 89.2% remains the same compared to f9fd5e1
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Stephan202 Stephan202 deleted the sschroevers/fix-javadoc-generation branch Jan 3, 2020
@Stephan202 Stephan202 added this to the 0.0.2 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.