Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
New controls, trouing rails, various patches #15
New Controls:LEFT or RIGHT to switch track at junction
I haven't been able to reproduce the "sudden reversal" problem reliably enough to try and patch that yet.
There are some spacing and comment changes in here that happened as I was trying to figure out the code, none of that is important and if they annoy you can be removed.
I'm new to Lua and minetest, so do not hesitate to critique or correct any coding errors I've made.
The deeper I get into the carts code, the more I realize how awesome and complicated the original mod is. Thank you for considering these changes!
I used your patches and my server crashed after a while. I have long rails with many up&downs.. a few carts running around... and suddenly I got this error message on the server: https://gist.github.com/LotekHeavy/725fd76cd7a4ce5f8073
Till know I couldn't reproduce this, sorry.
There's some good stuff in this patch series but it's combining multiple things into one large patches.
Can you split up your commits so it's easier to merge/review parts of it?
e.g. the part where the player can punch the cart while riding the cart should just be a single commit.
split out the whitespace cleanups into a separate commit
Add the new nodes and craft recipes in a separate commit.
Obviously this needs rebasing, otherwise it's not going to get merged.
sofar thank you very much for your comments. When I did this, I hadn't ever worked on a collaborative git project before, so I hadn't even considered separating my modifications into smaller bite-size chunks so that they would be easier to process for pull requests. Makes perfect sense. Sometime when I get time I will consider going through and rebasing this. thank you.