Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oled lib fix for p8 i2c #26

Merged
merged 2 commits into from May 6, 2022

Conversation

PaoloDooM
Copy link

@PaoloDooM PaoloDooM commented May 5, 2022

IMG_20220505_025000
Fix OLED lib for P18FX550 microcontrollers and sdd1306 display (i2c protocol) .

@MefhigosetH
Copy link
Member

Dear @PaoloDooM , welcome to the Pingüino Community, and welcome to GitHub too ;-) Thanks for your contribution.

I don't have an OLED at this moment to test this PR, but if your have tested it and works, I'll merge it.

I will wait for your feedback. Best regards.

@PaoloDooM
Copy link
Author

@MefhigosetH thanks for the welcome, I managed to test the changes on a pic18f2550 using a sdd1306 under i2c protocol, in this branch are two corrections, a syntax correction in OLED.h and a conditional addition in OLED.c that sets the correct clock for i2c protocol on pic18f2250 and pic18f4550.

VID_20220505_024926.mp4

@MefhigosetH MefhigosetH merged commit d59fdaf into PinguinoIDE:master May 6, 2022
@MefhigosetH
Copy link
Member

Merged 🎉

@PaoloDooM
Copy link
Author

Merged 🎉

Woohoo 🥳 thanks!!

@PaoloDooM PaoloDooM deleted the OLED_lib_fix_for_P8_I2C branch May 6, 2022 03:14
@PaoloDooM PaoloDooM changed the title Oled lib fix for p8 i2 c Oled lib fix for p8 i2c May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants