[Fixes bug #1074822] Fix alignment of PaintBrush, Eraser, Line, Rectangle and Text tool cursors #41

Merged
merged 6 commits into from Nov 23, 2012

2 participants

@don-mccomb

No description provided.

@cameronwhite cameronwhite commented on an outdated diff Nov 22, 2012
Pinta.Core/Enumerations/Shape.cs
+//
+// The above copyright notice and this permission notice shall be included in
+// all copies or substantial portions of the Software.
+//
+// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+// THE SOFTWARE.
+using System;
+
+namespace Pinta.Core
+{
+ public enum Shape
@cameronwhite
Pinta member

It might be better to rename this to be more descriptive - eg. CursorShape

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@cameronwhite
Pinta member

The changes look ok overall, but I noticed a couple visual issues:

  • The ellipse looks somewhat blurry for larger cursor sizes. I can't seem to get a screenshot of this, though.
  • The drop shadow on the canvas looks thinner than before on the right/bottom sides, and seems to have disappeared on the left and top sides.
@cameronwhite cameronwhite merged commit 0fbf668 into PintaProject:master Nov 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment